[jira] [Commented] (GEODE-8894) Allow individual deltas to trigger bucket size recalculation

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278392#comment-17278392 ] 

ASF GitHub Bot commented on GEODE-8894:
---------------------------------------

ringles commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r569789677



##########
File path: geode-core/src/main/java/org/apache/geode/Delta.java
##########
@@ -53,7 +51,13 @@
    * This method throws an {@link InvalidDeltaException} when the delta in the {@link DataInput}
    * cannot be applied to the object. GemFire automatically handles an {@link InvalidDeltaException}
    * by reattempting the update by sending the full application object.
-   *
    */
   void fromDelta(DataInput in) throws IOException, InvalidDeltaException;
+
+  /**
+   * Allows Delta implementations to ensure bucket sizes are recalculated after delta is applied

Review comment:
       Missed the "@SInCE 1.14" the first time, adding now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow individual deltas to trigger bucket size recalculation
> ------------------------------------------------------------
>
>                 Key: GEODE-8894
>                 URL: https://issues.apache.org/jira/browse/GEODE-8894
>             Project: Geode
>          Issue Type: New Feature
>          Components: core, serialization
>    Affects Versions: 1.14.0
>            Reporter: Raymond Ingles
>            Priority: Major
>
> The Redis subsystem uses Deltas heavily, but by default deltas do not trigger an update to the size of their buckets. This leads to incorrect memory usage accounting over the long term, especially with the use of Redis commands like "APPEND".
> It is possible to set the system property "DELTAS_RECALCULATE_SIZE", but this is a global value that would affect the processing of all deltas, including non-Redis operations.
> Instead, we will add a new default method to the Delta interface, that can be overridden by individual Delta implementations (such as Redis). This will trigger the same behavior as DELTAS_RECALCULATE_SIZE, but on a per-delta basis. Thus, other Geode operations will not force bucket size recalculations unless the global property is set, but Redis statistics will be correct.
> Other types of delta operations may find this useful in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)