[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391#discussion_r789266542



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
##########
@@ -653,6 +653,12 @@ private RunResult fork( Object testSet, PropertiesWrapper providerProperties, Fo
             {
                 runResult = timeout( reporter.getGlobalRunStatistics().getRunResult() );
             }
+            else if ( forkClient.isErrorInFork() )
+            {
+                final StackTraceWriter stackTrace = forkClient.getErrorInFork();
+                booterForkException =
+                    new SurefireBooterForkException( stackTrace.writeTraceToString() );
+            }

Review comment:
       @fl4via
   Pls have a look at the comments and answers. How can we continue with this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org