You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/22 14:37:23 UTC
[GitHub] [cloudstack] SadiJr commented on a diff in pull request #6282: [Veeam] restored VMs without NICs
SadiJr commented on code in PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#discussion_r856297539
##########
engine/schema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java:
##########
@@ -212,7 +212,7 @@ public NicVO findByNetworkIdAndMacAddress(long networkId, String mac) {
SearchCriteria<NicVO> sc = AllFieldsSearch.create();
sc.setParameters("network", networkId);
sc.setParameters("macAddress", mac);
- return findOneBy(sc);
+ return findOneIncludingRemovedBy(sc);
Review Comment:
Done, thanks for the suggestion.
##########
engine/schema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java:
##########
@@ -212,7 +212,7 @@ public NicVO findByNetworkIdAndMacAddress(long networkId, String mac) {
SearchCriteria<NicVO> sc = AllFieldsSearch.create();
sc.setParameters("network", networkId);
sc.setParameters("macAddress", mac);
- return findOneBy(sc);
+ return findOneIncludingRemovedBy(sc);
Review Comment:
Done, thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org