You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/13 22:57:37 UTC
Review Request 35431: Enable Option to hold a noncopyable type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35431/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
Diff: https://reviews.apache.org/r/35431/diff/
Testing
-------
Added tests for `Option<NonCopyable>` and ran `make check`.
Thanks,
Michael Park
Re: Review Request 35431: Enable Option to hold a noncopyable type.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35431/#review87847
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34276, 34517, 35431]
All tests passed.
- Mesos ReviewBot
On June 13, 2015, 8:57 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35431/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 8:57 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
>
> Diff: https://reviews.apache.org/r/35431/diff/
>
>
> Testing
> -------
>
> Added tests for `Option<NonCopyable>` and ran `make check`.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35431: Enable Option to hold a noncopyable type.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35431/#review87855
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 13, 2015, 8:57 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35431/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 8:57 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
>
> Diff: https://reviews.apache.org/r/35431/diff/
>
>
> Testing
> -------
>
> Added tests for `Option<NonCopyable>` and ran `make check`.
>
>
> Thanks,
>
> Michael Park
>
>