You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/10 18:15:18 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12007: [ZK Tests] Add breaks to prevent fall through in MockZooKeeper

michaeljmarshall opened a new pull request #12007:
URL: https://github.com/apache/pulsar/pull/12007


   ### Motivation
   
   With @lhotari's help, I ran the errorprone lombok check against Pulsar. It identified that the switch block modified here had potential fall through cases. Given the context of the method, it looks like the cases shouldn't allow the logic to fall through.
   
   ### Modifications
   
   * Corrected the logic in `MockZooKeeper#multi` by adding `break;` lines.
   
   ### Verifying this change
   
   This change is a trivial rework that does not require test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   No
   
   ### Documentation
   No doc updates required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] aahmed-se merged pull request #12007: [ZK Tests] Add breaks to prevent fall through in MockZooKeeper

Posted by GitBox <gi...@apache.org>.
aahmed-se merged pull request #12007:
URL: https://github.com/apache/pulsar/pull/12007


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #12007: [ZK Tests] Add breaks to prevent fall through in MockZooKeeper

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12007:
URL: https://github.com/apache/pulsar/pull/12007#issuecomment-917165772


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org