You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/05/14 06:15:43 UTC
[GitHub] [openmeetings] solomax commented on a change in pull request #85: [OPENMEETINGS-2349] new chromium-edge detection method and fixes
solomax commented on a change in pull request #85:
URL: https://github.com/apache/openmeetings/pull/85#discussion_r424893185
##########
File path: openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
##########
@@ -211,7 +211,11 @@ var VideoUtil = (function() {
}
function _isEdge(_b) {
const b = _b || kurentoUtils.WebRtcPeer.browser;
- return b.name === 'Edge';
+ return b.name === 'Edge' && "MSGestureEvent" in window;
+ }
+ function _isEdgeChromium(_b) {
+ const b = _b || kurentoUtils.WebRtcPeer.browser;
+ return b.name === 'Edge' && !("MSGestureEvent" in window);
Review comment:
Why not to use `b.major > 80` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org