You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2017/03/23 21:36:53 UTC

Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs
-----

  common/src/java/org/apache/hive/http/HttpServer.java db5650d0d2695011cfb07b23950bd611186a25f6 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 9eaa7d731b07352757237a5d26d1229ca34f35a0 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c484801c4fe1f5aa4f194520cdb22a07f2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1c4730fd3e95fb17dfb08d0f420097680a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e9f51a53f38da9caea5366a32e3e4ed7c3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c1847425fd1592e3645f39b355ff76fca435c749 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java a9d03d060adeaa5cad6bef48a63c048f23819d01 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 6d6c608fafe8935b3d1ba02f6a304db2034eef47 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f67394704f08fd019d0739cb4f76942e10d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 02827635873ffc319fca40fefbb3cea0fdc4c418 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 07aa2ea6a3006ad4cf4629d4c44cb4d3781d4db6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b301e96a9317df9fa251955d62db943a56a9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 984924368a854d4c6dd55c8f7b30b756461fe70d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd44fa780b545d102b3b533cb495835b4b71 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765e0a822c96b79e28b658dd8cbb5a401842 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b701d0f29dc1a26e9b7b8662103c888252c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344ce5c07dd5480aee930447034e4285a407 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af19a3b44bb588ea3d449ba2030612946a5e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af09780b89482b4a8b8a52682af4d6eeb6d915 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca5789ebead7694c2610b7dc0617f798fe6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533d382e8c35fb04fa377684850656450590 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff26a133ec37773eb7128807136eeccbb36e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe17506ed0b600bbaf5a2cc2b07f6af6a302628 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddcfdb61717eb0a2424650673d07884d9293 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985fbf91cb2a582bd0ca4245eabfbcb7a2bba 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee931163ed1c3645aefde4f4583a96fbbbbe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f8541321747c7c005e772e9d99597e1880020b82 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java cb3041382918d5005a261f3ae767cb475e318e56 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951d7aab3c163b6ca6d4a74520c92876f72b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c27e5564f1c778a246a9306d469736fc6eb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e624b7f414d5d6b84b836de0fce5645f740 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d88c35067c70e0c6273afe4b40ffc25aeb5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0f67347f2847d31df6a2c851c6c43422c4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d1d61acb434dfde260207cd298046fb1bf 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fdedc6a709e940065a572cd05c0193880e9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f0f7edb3a7ff5315d57689e55d79a2fa15 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a200551829020ff9a4e925d2a5596fe8f4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65aba835ca0c0b1586f2e4509b45f89be55d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e80e10af3c7aaed6c9dc00eac61448e4976 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d399395401a1f0e1b0f963123b37408a1c1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb0726050a15c4c7884004d0c6a0d966495 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java b93e9779e6ae030855105cdd7f76dc5ba8665c94 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 8bfa07c78d046227e10fc6ebd237fd6c17386a30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java fc5aea5152812bd7dbf04d6e6db9dd807452c07d 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306ff1383b4ff26195b2b0b7b87de55ed322 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8318a6276174de9721edee30f6576042110fa141 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java d9f70a72ece087127564b5eb60c6099f6cbf54e5 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d091b09f27080a199f248d92bc610337f781 


Diff: https://reviews.apache.org/r/57893/diff/1/


Testing
-------


Thanks,

Prasanth_J


Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

(Updated May 26, 2017, 9:28 p.m.)


Review request for hive, Gopal V and Siddharth Seth.


Changes
-------

Rebased patch.


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs (updated)
-----

  common/src/java/org/apache/hive/http/HttpServer.java 0bc0032 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 7f8c947 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java f3c571a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java af5e90f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 4971707 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 48dfedc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 7eaad18 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java 106a534 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java c4d5113 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java 10bc902 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 54e667c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java 99819cf 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8fb7211 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 6844713 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 


Diff: https://reviews.apache.org/r/57893/diff/6/

Changes: https://reviews.apache.org/r/57893/diff/5-6/


Testing
-------


Thanks,

Prasanth_J


Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

(Updated April 11, 2017, 9:55 p.m.)


Review request for hive, Gopal V and Siddharth Seth.


Changes
-------

Minor changes to http headers.


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs (updated)
-----

  common/src/java/org/apache/hive/http/HttpServer.java fd3d457 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 7f8c947 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 4d727ba 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 6d6c608 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 07aa2ea 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java cb30413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java b93e977 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 8bfa07c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java fc5aea5 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8fb7211 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 6844713 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 


Diff: https://reviews.apache.org/r/57893/diff/5/

Changes: https://reviews.apache.org/r/57893/diff/4-5/


Testing
-------


Thanks,

Prasanth_J


Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

(Updated April 11, 2017, 9:10 p.m.)


Review request for hive, Gopal V and Siddharth Seth.


Changes
-------

Addressed Gopal's review comments.


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs (updated)
-----

  common/src/java/org/apache/hive/http/HttpServer.java fd3d457 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 7f8c947 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 4d727ba 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 6d6c608 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 07aa2ea 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java cb30413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java b93e977 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 8bfa07c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java fc5aea5 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8fb7211 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 6844713 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 


Diff: https://reviews.apache.org/r/57893/diff/4/

Changes: https://reviews.apache.org/r/57893/diff/3-4/


Testing
-------


Thanks,

Prasanth_J


Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

(Updated April 4, 2017, 10:38 p.m.)


Review request for hive and Siddharth Seth.


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs (updated)
-----

  common/src/java/org/apache/hive/http/HttpServer.java fd3d457 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 4f2e325 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java a9d03d0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 6d6c608 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 07aa2ea 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java cb30413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java b93e977 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 8bfa07c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java fc5aea5 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8fb7211 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 6844713 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 


Diff: https://reviews.apache.org/r/57893/diff/3/

Changes: https://reviews.apache.org/r/57893/diff/2-3/


Testing
-------


Thanks,

Prasanth_J


Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

(Updated March 24, 2017, 12:11 a.m.)


Review request for hive.


Changes
-------

Updated javadoc


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs (updated)
-----

  common/src/java/org/apache/hive/http/HttpServer.java db5650d 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 9eaa7d7 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java a9d03d0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 6d6c608 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 07aa2ea 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java cb30413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java b93e977 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 8bfa07c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java fc5aea5 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8318a62 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java d9f70a7 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 


Diff: https://reviews.apache.org/r/57893/diff/2/

Changes: https://reviews.apache.org/r/57893/diff/1-2/


Testing
-------


Thanks,

Prasanth_J