[GitHub] incubator-apex-malhar pull request: MLHR-1958: Adding getter for d...

[gauravgopi123 <gi...@git.apache.org>]

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/149#discussion_r48622315
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractReconciler.java ---
    @@ -187,6 +189,18 @@ public void run()
       }
     
       /**
    +   * Returns the unmodifiable collection of the tuples on which
    +   * processCommittedData has been called in this window. Underlying collection
    +   * is cleared at every endWindow() of AbstractReconciler.
    +   * 
    +   * @return done tuples
    +   */
    +  protected Collection<QUEUETUPLE> getDoneTuples()
    +  {
    +    return Collections.unmodifiableCollection(doneTuples);
    +  }
    --- End diff --
    
    Can you give details about the usecase why you need only read view and not write view? Why even read view is required as I think this is internal to operator?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---