You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Christoph Läubrich (JIRA)" <ji...@apache.org> on 2013/02/09 09:49:12 UTC

[jira] [Commented] (WICKET-4945) Wicket-atmosphere filters should be functions on AtmosphereResource

    [ https://issues.apache.org/jira/browse/WICKET-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575118#comment-13575118 ] 

Christoph Läubrich commented on WICKET-4945:
--------------------------------------------

I'll vote for this! The predicate also creates a dependecy on google jsut for the sake of using one single interface. A Wicket specific one would be mor appropiate and handling over the AtmosphereResource also would help for corner cases.
                
> Wicket-atmosphere filters should be functions on AtmosphereResource
> -------------------------------------------------------------------
>
>                 Key: WICKET-4945
>                 URL: https://issues.apache.org/jira/browse/WICKET-4945
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-atmosphere
>    Affects Versions: 6.4.0
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>
> With a function on AtmosphereResource, rather than a predicate, it is possible to filter on attributes in the AtmosphereRequest. This would allow you to create filters that differentiate on the receiver, without relying on the heavy-weight contextAwareFilter().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira