You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ashwani Raina (Code Review)" <ge...@cloudera.org> on 2025/06/13 15:43:31 UTC
[kudu-CR] [net] KUDU-1457 [3/n] Add support for IPv6
Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23021
Change subject: [net] KUDU-1457 [3/n] Add support for IPv6
......................................................................
[net] KUDU-1457 [3/n] Add support for IPv6
As part of adding IPv6 support, this patch adds support for IPv6
in diagnostic socket implementation and its corresponding unit tests.
- Modify TcpSocketInfo structure fields to enable src_addr and
dst_addr to store IPv6 addresses as well.
- Add changes in SendRequest and ReceiveResponse to accommodate
IPv6 addresses in request structure.
- Add corresponding unit tests i.e. ListeningSocket and SimplePattern
for IPv6 addresses.
Note: This patch has a dependency on following unmerged patch [1] that
is currently open for review.
[1] https://gerrit.cloudera.org/c/22984/
DONT_BUILD
Depends-On: I22c773ffb2ff44b9cd765b546d6724ec5543586f
Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
---
M src/kudu/util/net/diagnostic_socket-test.cc
M src/kudu/util/net/diagnostic_socket.cc
M src/kudu/util/net/diagnostic_socket.h
3 files changed, 208 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23021/1
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@cloudera.com>
[kudu-CR] [net] KUDU-1457 [3/n] Add support for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: [net] KUDU-1457 [3/n] Add support for IPv6
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1449/
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Jun 2025 15:43:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@202
PS1, Line 202: addr_.ipv6_addr().s
> I didn't try it. I believe IPv6 tests should fail at the time of bind, in s
I think it's OK to add the IPv6 detection logic later in a separate patch, if needed. As of now, most public cloud providers and Unix-flavor OS distributions have IPv6 enabled by default when creating an new instance of runtime environment.
As an alternative, we might consider start requiring IPv6 support for Apache Kudu development activities.
http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc@111
PS4, Line 111: ASSERT_FALSE(memcmp(src_addr.ipv6_addr().sin6_addr.s6_addr,
: entry.src_addr, sizeof(entry.src_addr)));
: ASSERT_FALSE(memcmp(&in6addr_any, entry.dst_addr, sizeof(entry.dst_addr)));
nit for the future: please use ASSERT_EQ(0, ...) in such cases, similar to other matching cases elsewhere in this file involving memcmp()
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 19:24:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23021/3/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/3/src/kudu/util/net/diagnostic_socket-test.cc@195
PS3, Line 195: ddr[0], INADDR_
> Curious on why not to use the standard 127.0.0.1, although it doesn't make
I don't think it should matter. Both are from 127.0.0.0/8 range that are reserved for loopback addresses.
I just kept the same address for IPv4 as before from original change.
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 05 Aug 2025 06:32:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 3: Code-Review+1
First pass looks good, I'll take another look tomorrow.
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Aug 2025 01:36:43 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23021/3/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/3/src/kudu/util/net/diagnostic_socket-test.cc@195
PS3, Line 195: 127.254.254.254
Curious on why not to use the standard 127.0.0.1, although it doesn't make any difference?
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 05 Aug 2025 02:33:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1629/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 29 Jul 2025 14:19:17 +0000
Gerrit-HasComments: No
[kudu-CR] [net] KUDU-1457 [3/n] Add support for IPv6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: [net] KUDU-1457 [3/n] Add support for IPv6
......................................................................
Patch Set 1: Code-Review+1
(11 comments)
Overall looks good, just a few nits.
http://gerrit.cloudera.org:8080/#/c/23021/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23021/1//COMMIT_MSG@18
PS1, Line 18: Note: This patch has a dependency on following unmerged patch [1] that
: is currently open for review.
:
: [1] https://gerrit.cloudera.org/c/22984/
This piece will be removed when submitting/committing this patch to the repo, right?
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@60
PS1, Line 60: ListeningSocket
style nit: in this case, the name of the method should include verbs to reflect its main purpose/action, e.g. GetListeningSocketInfo()
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@82
PS1, Line 82: SimplePattern
Ditto for the function/method name.
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@136
PS1, Line 136: if (src_addr.ipv4_addr().sin_addr.s_addr != entry.src_addr[0] ||
: INADDR_ANY != entry.dst_addr[0]) {
: return false;
: }
nit for here and below: remove the 'if (!condition) {}' clause and replace with 'return condition;'
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@189
PS1, Line 189: = {}
Why is this now necessary? If it's about zeroing out some fields, it's much better doing so in the constructor instead of doing so every time at call sites.
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@191
PS1, Line 191: ListeningSocket("127.254.254.254", &info);
Wrap into NO_FATALS()?
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@205
PS1, Line 205: ListeningSocket("::1", &info)
Wrap into NO_FATALS()?
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@208
PS1, Line 208: ASSERT_EQ
nit for here and elsewhere: in EXPECT_EQ/ASSERT_EQ the expected value comes -- that way it's easier to comprehend the error message if this assertion ever triggers
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h
File src/kudu/util/net/diagnostic_socket.h:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h@59
PS1, Line 59: IPv4
Update this as well?
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.cc
File src/kudu/util/net/diagnostic_socket.cc:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.cc@185
PS1, Line 185: if (socket_src_addr.family() == AF_INET && socket_dst_addr.family() == AF_INET) {
: const in_addr& src_ipv4 = socket_src_addr.ipv4_addr().sin_addr;
: const auto src_port = socket_src_addr.port();
: const in_addr& dst_ipv4 = socket_dst_addr.ipv4_addr().sin_addr;
: const auto dst_port = socket_dst_addr.port();
:
: // All values in inet_diag_sockid and in_addr are in network byte order.
: sock_id = (struct inet_diag_sockid) {
: .idiag_sport = htons(src_port),
: .idiag_dport = htons(dst_port),
: .idiag_src = { src_ipv4.s_addr, 0, 0, 0, },
: .idiag_dst = { dst_ipv4.s_addr, 0, 0, 0, },
: .idiag_if = kWildcard,
: .idiag_cookie = { kWildcard, kWildcard },
: };
: } else if (socket_src_addr.family() == AF_INET6 && socket_dst_addr.family() == AF_INET6) {
: const in6_addr& src_ipv6 = socket_src_addr.ipv6_addr().sin6_addr;
: const auto src_port = socket_src_addr.port();
: const in6_addr& dst_ipv6 = socket_dst_addr.ipv6_addr().sin6_addr;
: const auto dst_port = socket_dst_addr.port();
:
: // All values in inet_diag_sockid and in6_addr are in network byte order.
: sock_id = (struct inet_diag_sockid) {
: .idiag_sport = htons(src_port),
: .idiag_dport = htons(dst_port),
: .idiag_src = { src_ipv6.s6_addr32[0],
: src_ipv6.s6_addr32[1],
: src_ipv6.s6_addr32[2],
: src_ipv6.s6_addr32[3], },
: .idiag_dst = { dst_ipv6.s6_addr32[0],
: dst_ipv6.s6_addr32[1],
: dst_ipv6.s6_addr32[2],
: dst_ipv6.s6_addr32[3], },
: .idiag_if = kWildcard,
: .idiag_cookie = { kWildcard, kWildcard },
: };
Instead of this boilerplate with duplicated code, could you rewrite it using ternary operator to assign the fields of the inet_diag_sockid structure (maybe, introducing temporary variables of type 'auto' if you need them)?
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.cc@337
PS1, Line 337: IPv4 or IPv6 addresses
nit for here and elsewhere: does it make sense to replace 'IPv4 and/or IPv6 address' with 'IP address' in the comments throughout the code?
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jul 2025 01:48:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [net] KUDU-1457 [3/n] Add support for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: [net] KUDU-1457 [3/n] Add support for IPv6
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/23021/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23021/1//COMMIT_MSG@18
PS1, Line 18: Note: This patch has a dependency on following unmerged patch [1] that
: is currently open for review.
:
: [1] https://gerrit.cloudera.org/c/22984/
> This piece will be removed when submitting/committing this patch to the rep
Yes
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@60
PS1, Line 60: ListeningSocket
> style nit: in this case, the name of the method should include verbs to ref
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@82
PS1, Line 82: SimplePattern
> Ditto for the function/method name.
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@136
PS1, Line 136: if (src_addr.ipv4_addr().sin_addr.s_addr != entry.src_addr[0] ||
: INADDR_ANY != entry.dst_addr[0]) {
: return false;
: }
> nit for here and below: remove the 'if (!condition) {}' clause and replace
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@189
PS1, Line 189: = {}
> Why is this now necessary? If it's about zeroing out some fields, it's muc
I don't remember why I added this. Maybe, the code was still under testing and to make sure I am not hitting any garbage value post population failure, I may have left it there.
This is not required since Query is going to fill it up with values in all good cases. Removed.
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@191
PS1, Line 191: ListeningSocket("127.254.254.254", &info);
> Wrap into NO_FATALS()?
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@202
PS1, Line 202: ListeningSocketIpV6
> BTW, did you try to run this test on a machine where IPv6 support is disabl
I didn't try it. I believe IPv6 tests should fail at the time of bind, in such scenario.
Eventually, we can have such detect conditions. I am planning to add more tests in subsequent changes that are going to use IPv6 addresses. At that time, it would make sense to have some common approach (preferably common code as well) for all such cases. Different OSes will have different ways to determine whether IPv6 is disabled or not. All those need to be taken into consideration.
Do you see any issue in leaving these IPv6 tests as is (along with a comment stating the behaviour in such scenario) and add detection logic later?
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@205
PS1, Line 205: ListeningSocket("::1", &info)
> Wrap into NO_FATALS()?
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@208
PS1, Line 208: ASSERT_EQ
> nit for here and elsewhere: in EXPECT_EQ/ASSERT_EQ the expected value comes
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h
File src/kudu/util/net/diagnostic_socket.h:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h@59
PS1, Line 59: IPv4
> Update this as well?
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.cc
File src/kudu/util/net/diagnostic_socket.cc:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.cc@185
PS1, Line 185: if (socket_src_addr.family() == AF_INET && socket_dst_addr.family() == AF_INET) {
: const in_addr& src_ipv4 = socket_src_addr.ipv4_addr().sin_addr;
: const auto src_port = socket_src_addr.port();
: const in_addr& dst_ipv4 = socket_dst_addr.ipv4_addr().sin_addr;
: const auto dst_port = socket_dst_addr.port();
:
: // All values in inet_diag_sockid and in_addr are in network byte order.
: sock_id = (struct inet_diag_sockid) {
: .idiag_sport = htons(src_port),
: .idiag_dport = htons(dst_port),
: .idiag_src = { src_ipv4.s_addr, 0, 0, 0, },
: .idiag_dst = { dst_ipv4.s_addr, 0, 0, 0, },
: .idiag_if = kWildcard,
: .idiag_cookie = { kWildcard, kWildcard },
: };
: } else if (socket_src_addr.family() == AF_INET6 && socket_dst_addr.family() == AF_INET6) {
: const in6_addr& src_ipv6 = socket_src_addr.ipv6_addr().sin6_addr;
: const auto src_port = socket_src_addr.port();
: const in6_addr& dst_ipv6 = socket_dst_addr.ipv6_addr().sin6_addr;
: const auto dst_port = socket_dst_addr.port();
:
: // All values in inet_diag_sockid and in6_addr are in network byte order.
: sock_id = (struct inet_diag_sockid) {
: .idiag_sport = htons(src_port),
: .idiag_dport = htons(dst_port),
: .idiag_src = { src_ipv6.s6_addr32[0],
: src_ipv6.s6_addr32[1],
: src_ipv6.s6_addr32[2],
: src_ipv6.s6_addr32[3], },
: .idiag_dst = { dst_ipv6.s6_addr32[0],
: dst_ipv6.s6_addr32[1],
: dst_ipv6.s6_addr32[2],
: dst_ipv6.s6_addr32[3], },
: .idiag_if = kWildcard,
: .idiag_cookie = { kWildcard, kWildcard },
: };
> Instead of this boilerplate with duplicated code, could you rewrite it usin
Done
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.cc@337
PS1, Line 337: IPv4 or IPv6 addresses
> nit for here and elsewhere: does it make sense to replace 'IPv4 and/or IPv6
Readability-wise, it would be better to have explicit mention of both to avoid any confusion and additional effort to figure out whether code block does handle both case or not. Additionally, there are multiple places in the code where "IP address" is mentioned in comments and only IPv4 is handled there.
Eventually, having "IP address" everywhere is desirable. Till then, explicit mention of IPv6 will provide assertive information about handling.
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 29 Jul 2025 14:01:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 4: Verified+1 Code-Review+2
LGTM!
unrelated test failures:
debug: ts_authz-itest.0, auto_rebalancer-test.0, org.apache.kudu.backup.TestKuduBackup
tsan: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 09:37:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 21:36:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
KUDU-1457 [3/n] add IPv6 support for diagnostic socket
As part of adding IPv6 support, this patch adds support for IPv6
in diagnostic socket implementation and its corresponding unit tests.
- Modify TcpSocketInfo structure fields to enable src_addr and
dst_addr to store IPv6 addresses as well.
- Add changes in SendRequest and ReceiveResponse to accommodate
IPv6 addresses in request structure.
- Add corresponding unit tests i.e. ListeningSocket and SimplePattern
for IPv6 addresses.
Depends-On: I22c773ffb2ff44b9cd765b546d6724ec5543586f
Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Reviewed-on: http://gerrit.cloudera.org:8080/23021
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/net/diagnostic_socket-test.cc
M src/kudu/util/net/diagnostic_socket.cc
M src/kudu/util/net/diagnostic_socket.h
3 files changed, 204 insertions(+), 123 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 4:
(2 comments)
Overall looks solid, two questions.
First pass from my end. Will do another tomorrow.
http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc@133
PS4, Line 133: const auto compare_addresses = [&](DiagnosticSocket::TcpSocketInfo entry) {
: if (family == AF_INET) {
: // IPv4 comparison
: return (src_addr.ipv4_addr().sin_addr.s_addr == entry.src_addr[0] &&
: INADDR_ANY == entry.dst_addr[0]);
: }
: // IPv6 comparison
: return (memcmp(src_addr.ipv6_addr().sin6_addr.s6_addr,
: entry.src_addr, sizeof(entry.src_addr)) == 0 &&
: memcmp(&in6addr_any, entry.dst_addr,
: sizeof(entry.dst_addr)) == 0);
: };
This lambda looks like functionality that could pop up elsewhere. I'm not sure whether it would make sense to add this as a method to TcpSocketInfo?
As I see it is only used in this test once. Just a curiosity question.
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h
File src/kudu/util/net/diagnostic_socket.h:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h@64
PS1, Line 64:
doc nit: maybe explicitly mention ipv6 in the todo as well
Sockaddr class fields (supporting both IPv4 and IPv6).
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Sep 2025 14:50:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1629/
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 29 Jul 2025 14:06:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23021
to look at the new patch set (#4).
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
KUDU-1457 [3/n] add IPv6 support for diagnostic socket
As part of adding IPv6 support, this patch adds support for IPv6
in diagnostic socket implementation and its corresponding unit tests.
- Modify TcpSocketInfo structure fields to enable src_addr and
dst_addr to store IPv6 addresses as well.
- Add changes in SendRequest and ReceiveResponse to accommodate
IPv6 addresses in request structure.
- Add corresponding unit tests i.e. ListeningSocket and SimplePattern
for IPv6 addresses.
Depends-On: I22c773ffb2ff44b9cd765b546d6724ec5543586f
Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
---
M src/kudu/util/net/diagnostic_socket-test.cc
M src/kudu/util/net/diagnostic_socket.cc
M src/kudu/util/net/diagnostic_socket.h
3 files changed, 204 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23021/4
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23021
to look at the new patch set (#2).
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
KUDU-1457 [3/n] add IPv6 support for diagnostic socket
As part of adding IPv6 support, this patch adds support for IPv6
in diagnostic socket implementation and its corresponding unit tests.
- Modify TcpSocketInfo structure fields to enable src_addr and
dst_addr to store IPv6 addresses as well.
- Add changes in SendRequest and ReceiveResponse to accommodate
IPv6 addresses in request structure.
- Add corresponding unit tests i.e. ListeningSocketInfo and
SimplePattern for IPv6 addresses.
Note: This patch has a dependency on following unmerged patch [1] that
is currently open for review.
[1] https://gerrit.cloudera.org/c/22984/
DONT_BUILD
Depends-On: I22c773ffb2ff44b9cd765b546d6724ec5543586f
Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
---
M src/kudu/util/net/diagnostic_socket-test.cc
M src/kudu/util/net/diagnostic_socket.cc
M src/kudu/util/net/diagnostic_socket.h
3 files changed, 196 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23021/2
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23021
to look at the new patch set (#3).
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
KUDU-1457 [3/n] add IPv6 support for diagnostic socket
As part of adding IPv6 support, this patch adds support for IPv6
in diagnostic socket implementation and its corresponding unit tests.
- Modify TcpSocketInfo structure fields to enable src_addr and
dst_addr to store IPv6 addresses as well.
- Add changes in SendRequest and ReceiveResponse to accommodate
IPv6 addresses in request structure.
- Add corresponding unit tests i.e. ListeningSocket and SimplePattern
for IPv6 addresses.
Note: This patch has a dependency on following unmerged patch [1] that
is currently open for review.
[1] https://gerrit.cloudera.org/c/22984/
DONT_BUILD
Depends-On: I22c773ffb2ff44b9cd765b546d6724ec5543586f
Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
---
M src/kudu/util/net/diagnostic_socket-test.cc
M src/kudu/util/net/diagnostic_socket.cc
M src/kudu/util/net/diagnostic_socket.h
3 files changed, 196 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/23021/3
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 1:
(2 comments)
Thank you for the review.
http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc@133
PS4, Line 133: const auto compare_addresses = [&](DiagnosticSocket::TcpSocketInfo entry) {
: if (family == AF_INET) {
: // IPv4 comparison
: if (src_addr.ipv4_addr().sin_addr.s_addr != entry.src_addr[0] ||
: INADDR_ANY != entry.dst_addr[0]) {
: return false;
: }
: } else {
: // IPv6 comparison
: if (memcmp(src_addr.ipv6_addr().sin6_addr.s6_addr,
: entry.src_addr, sizeof(entry.src_addr)) != 0 ||
:
> This lambda looks like functionality that could pop up elsewhere. I'm not s
I can't think of any additional usage scenario right now. However, if such a need arises in future, it wouldn't harm to add this as a method to appropriate class under that patch.
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h
File src/kudu/util/net/diagnostic_socket.h:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket.h@64
PS1, Line 64: Sockaddr class fields.
> doc nit: maybe explicitly mention ipv6 in the todo as well
Sockaddr class supports IPv4, IPv6 and Unix domain family.
Replacing the pairs with Sockaddr class would inherently mean supporting sockets from IPv4 or IPv6 family.
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 06:45:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [net] KUDU-1457 [3/n] Add support for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: [net] KUDU-1457 [3/n] Add support for IPv6
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1449/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Jun 2025 15:43:51 +0000
Gerrit-HasComments: No
[kudu-CR] [net] KUDU-1457 [3/n] Add support for IPv6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: [net] KUDU-1457 [3/n] Add support for IPv6
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc
File src/kudu/util/net/diagnostic_socket-test.cc:
http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@202
PS1, Line 202: ListeningSocketIpV6
BTW, did you try to run this test on a machine where IPv6 support is disabled for all the network interfaces? In this context, do you think we need to detect such conditions and skip test scenarios like these if IPv6 isn't supported even at the loca loopback interface?
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jul 2025 03:03:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1754/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 16:56:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [3/n] add IPv6 support for diagnostic socket
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1754/
--
To view, visit http://gerrit.cloudera.org:8080/23021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 15:17:51 +0000
Gerrit-HasComments: No