You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (Jira)" <ji...@apache.org> on 2023/04/13 05:02:00 UTC

[jira] [Resolved] (SLING-1596) Reduce coupling between RequestData and SlingHttpServletRequestImpl

     [ https://issues.apache.org/jira/browse/SLING-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-1596.
-------------------------------------
    Resolution: Won't Fix

> Reduce coupling between RequestData and SlingHttpServletRequestImpl
> -------------------------------------------------------------------
>
>                 Key: SLING-1596
>                 URL: https://issues.apache.org/jira/browse/SLING-1596
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.6
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-1596.patch
>
>
> As discussed in http://markmail.org/thread/ldayz27ehldyvzr4 the tight coupling between RequestData and SlingHttpServletRequestImpl makes it impossible to use request classes that just implement SlingHttpServletRequest.
> I need this for example for SLING-550, where servlets run outside of the container's request/response cycle.
> I'll attach a patch that reduces coupling by grabbing the RequestData from a request attribute instead of relying on the SlingHttpServletRequestImpl class to provide it. All tests including integration pass with this patch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)