You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/02/02 19:40:17 UTC
Review Request 30513: Added validation for CREATE offer operation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs: MESOS-2100
https://issues.apache.org/jira/browse/MESOS-2100
Repository: mesos
Description
-------
Added validation for CREATE offer operation.
This depends on the master validator refactor. Tests will be in a different patch.
Diffs
-----
src/master/validation.hpp PRE-CREATION
src/master/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30513/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70867
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30513]
All tests passed.
- Mesos ReviewBot
On Feb. 3, 2015, 11:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 11:19 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
> src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
> src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
> src/tests/master_validation_tests.cpp PRE-CREATION
> src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70908
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30513]
All tests passed.
- Mesos ReviewBot
On Feb. 4, 2015, 1:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:10 a.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
> src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
> src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
> src/tests/master_validation_tests.cpp PRE-CREATION
> src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review71016
-----------------------------------------------------------
Ship it!
src/tests/master_validation_tests.cpp
<https://reviews.apache.org/r/30513/#comment116529>
Why do you need this fixture? Why not have ResourceValidationTest and CreateOperationValidationTest subclass Test class directly?
src/tests/master_validation_tests.cpp
<https://reviews.apache.org/r/30513/#comment116532>
Also add a test where validate returns None?
- Vinod Kone
On Feb. 4, 2015, 1:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:10 a.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
> src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
> src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
> src/tests/master_validation_tests.cpp PRE-CREATION
> src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 1:10 a.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Killed another unneeded test.
Bugs: MESOS-2100
https://issues.apache.org/jira/browse/MESOS-2100
Repository: mesos
Description
-------
Added validation for CREATE offer operation.
This depends on the master validator refactor. Tests will be in a different patch.
Diffs (updated)
-----
src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
src/tests/master_validation_tests.cpp PRE-CREATION
src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
Diff: https://reviews.apache.org/r/30513/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 11:19 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-2100
https://issues.apache.org/jira/browse/MESOS-2100
Repository: mesos
Description
-------
Added validation for CREATE offer operation.
This depends on the master validator refactor. Tests will be in a different patch.
Diffs (updated)
-----
src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
src/tests/master_validation_tests.cpp PRE-CREATION
src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
Diff: https://reviews.apache.org/r/30513/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 11:15 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Review comments. Added/refactored the tests.
Bugs: MESOS-2100
https://issues.apache.org/jira/browse/MESOS-2100
Repository: mesos
Description
-------
Added validation for CREATE offer operation.
This depends on the master validator refactor. Tests will be in a different patch.
Diffs (updated)
-----
src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
src/tests/master_validation_tests.cpp PRE-CREATION
src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
Diff: https://reviews.apache.org/r/30513/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 3, 2015, 8:15 p.m., Vinod Kone wrote:
> > Test?
Added/refactored tests.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
-----------------------------------------------------------
On Feb. 3, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
> src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
> src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
> src/tests/master_validation_tests.cpp PRE-CREATION
> src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 3, 2015, 8:15 p.m., Vinod Kone wrote:
> > src/master/validation.cpp, line 132
> > <https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line132>
> >
> > ditto.
It's clear that resource.name() is 'disk' in this case.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
-----------------------------------------------------------
On Feb. 3, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
> src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
> src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
> src/tests/master_validation_tests.cpp PRE-CREATION
> src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
-----------------------------------------------------------
Test?
src/master/validation.cpp
<https://reviews.apache.org/r/30513/#comment116254>
Include resource.name() for better debugging.
src/master/validation.cpp
<https://reviews.apache.org/r/30513/#comment116255>
ditto.
- Vinod Kone
On Feb. 2, 2015, 6:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 6:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/master/validation.hpp PRE-CREATION
> src/master/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
> > src/master/validation.cpp, line 126
> > <https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line126>
> >
> > s/resource/volumes/ .. the current code reads as if you're checking that all resources are persistent volumes, which confused me.
Fixed.
> On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
> > src/master/validation.cpp, line 544
> > <https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line544>
> >
> > if this is all you need, can you pass in the persisted resources instead of a slave? might make future testing easier.
>
> Vinod Kone wrote:
> +1 why does this need to take a Slave* ?
Fixed.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70600
-----------------------------------------------------------
On Feb. 3, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242
> src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4
> src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83
> src/tests/master_validation_tests.cpp PRE-CREATION
> src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
> > src/master/validation.cpp, line 544
> > <https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line544>
> >
> > if this is all you need, can you pass in the persisted resources instead of a slave? might make future testing easier.
+1 why does this need to take a Slave* ?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70600
-----------------------------------------------------------
On Feb. 2, 2015, 6:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 6:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/master/validation.hpp PRE-CREATION
> src/master/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70600
-----------------------------------------------------------
src/master/validation.hpp
<https://reviews.apache.org/r/30513/#comment115806>
const Slave* or const Slave&?
src/master/validation.cpp
<https://reviews.apache.org/r/30513/#comment115807>
s/resource/volumes/ .. the current code reads as if you're checking that all resources are persistent volumes, which confused me.
src/master/validation.cpp
<https://reviews.apache.org/r/30513/#comment115808>
if this is all you need, can you pass in the persisted resources instead of a slave? might make future testing easier.
- Dominic Hamon
On Feb. 2, 2015, 10:40 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 10:40 a.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/master/validation.hpp PRE-CREATION
> src/master/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30513: Added validation for CREATE offer operation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70626
-----------------------------------------------------------
Bad patch!
Reviews applied: [30513]
Failed command: ./support/apply-review.sh -n -r 30513
Error:
2015-02-02 21:23:42 URL:https://reviews.apache.org/r/30513/diff/raw/ [2114/2114] -> "30513.patch" [1]
error: src/master/validation.hpp: does not exist in index
error: src/master/validation.cpp: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Feb. 2, 2015, 6:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30513/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 6:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-2100
> https://issues.apache.org/jira/browse/MESOS-2100
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for CREATE offer operation.
>
> This depends on the master validator refactor. Tests will be in a different patch.
>
>
> Diffs
> -----
>
> src/master/validation.hpp PRE-CREATION
> src/master/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30513/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>