[GitHub] [iceberg] rdsr commented on a change in pull request #1321: Avro: Fix pruning columns when a logical-map array's value type is nested

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #1321:
URL: https://github.com/apache/iceberg/pull/1321#discussion_r468687292



##########
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
##########
@@ -144,16 +144,18 @@ public Schema array(Schema array, Schema element) {
       if (selectedIds.contains(keyId) || selectedIds.contains(valueId)) {
         return complexMapWithIds(array, keyId, valueId);
       } else if (element != null) {
-        Schema keyProjection = element.getField("key").schema();
+        Schema.Field keyProjectionField = element.getField("key");

Review comment:
       Hi @lxynov,  could you write a test to reproduce the issue? I don't completely understand it.  The description says that this fixes pruning if a  map's value is a complex type [nested], but the change is mostly a null check on the key field




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org