You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/20 00:46:00 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet

leezu opened a new pull request #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet
URL: https://github.com/apache/incubator-mxnet/pull/17878
 
 
   ## Description ##
   Don't share DMLC_LOG_FATAL_THROW preprocessor variable as TVMOP build is not stable. Instead, use MXNET_LOG_FATAL_THROW for MXNet.
   
   Workaround for https://github.com/apache/incubator-mxnet/issues/17875
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu commented on issue #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet
URL: https://github.com/apache/incubator-mxnet/pull/17878#issuecomment-602080713
 
 
   I updated the PR to preserve `DMLC_LOG_FATAL_THROW`, but only set it on the mxnet target.
   Previously `DMLC_LOG_FATAL_THROW` was configured globally, affecting both tvm and mxnet build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] yzhliu commented on issue #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet

Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet
URL: https://github.com/apache/incubator-mxnet/pull/17878#issuecomment-602758442
 
 
   @leezu thanks for the finding and fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu merged pull request #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet
URL: https://github.com/apache/incubator-mxnet/pull/17878
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu commented on issue #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17878: Decouple LOG_FATAL_THROW prepocessor variables between TVM and MXNet
URL: https://github.com/apache/incubator-mxnet/pull/17878#issuecomment-602089914
 
 
   @yzhliu I find that we always build TVM with OpenMP, even if OpenMP is disabled in MXNet. The comment
   
   ```
   # Use OPENMP thread pool to be compatible with MXNet
   set(USE_OPENMP ON)
   ```
   
   suggests that is unintended. I added a fix to disable building TVM OpenMP if it's disabled on MXNet side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services