You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Ryan Blue (JIRA)" <ji...@apache.org> on 2016/09/04 00:27:22 UTC

[jira] [Updated] (AVRO-1888) Java: Single-record encoding marker bytes check is incorrect

     [ https://issues.apache.org/jira/browse/AVRO-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Blue updated AVRO-1888:
----------------------------
    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I committed this. Thanks for reviewing, [~busbey]!

> Java: Single-record encoding marker bytes check is incorrect
> ------------------------------------------------------------
>
>                 Key: AVRO-1888
>                 URL: https://issues.apache.org/jira/browse/AVRO-1888
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>            Priority: Blocker
>             Fix For: 1.8.2
>
>         Attachments: AVRO-1888.1.patch
>
>
> It looks like the check for correct marker bytes is incorrect.
> The check should validate both marker/version bytes match what is expected, but is instead this:
> {code}
> if (! (BinaryMessageEncoder.V1_HEADER[0] == header[0])
>     && BinaryMessageEncoder.V1_HEADER[1] == header[1]) { . . . }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)