You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@crail.apache.org by PepperJo <gi...@git.apache.org> on 2018/06/20 11:42:07 UTC

[GitHub] incubator-crail pull request #26: Start script: remove heap size argument

GitHub user PepperJo opened a pull request:

    https://github.com/apache/incubator-crail/pull/26

    Start script: remove heap size argument

    Remove Xmx and MaxDirectMemorySize argument from start script
    since it does not allow to run Crail on machines with less
    than 64G.
    
    https://issues.apache.org/jira/browse/CRAIL-40
    
    Signed-off-by: Jonas Pfefferle <pe...@apache.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PepperJo/incubator-crail start_script

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-crail/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 7209748b399b8f6bcfbf4c87ff498dae3fd55e33
Author: Jonas Pfefferle <pe...@...>
Date:   2018-06-20T11:36:11Z

    Start script: remove heap size argument
    
    Remove Xmx and MaxDirectMemorySize argument from start script
    since it does not allow to run Crail on machines with less
    than 64G.
    
    https://issues.apache.org/jira/browse/CRAIL-40
    
    Signed-off-by: Jonas Pfefferle <pe...@apache.org>

----


---

[GitHub] incubator-crail pull request #26: Start script: remove heap size argument

Posted by PepperJo <gi...@git.apache.org>.

Github user PepperJo commented on a diff in the pull request:

    https://github.com/apache/incubator-crail/pull/26#discussion_r196793997
  
    --- Diff: bin/crail ---
    @@ -70,4 +70,4 @@ fi
     export CLASSPATH="$bin"/../jars/*:"$bin"/../conf:.
     export LD_LIBRARY_PATH="$bin/../lib:$LD_LIBRARY_PATH"
     
    -exec "$JAVA" -Dproc_$COMMAND -XX:MaxDirectMemorySize=64G -Dsun.nio.PageAlignDirectMemory=true -Xmn16G $CLASS "$@"
    +exec "$JAVA" -Dproc_$COMMAND -Dsun.nio.PageAlignDirectMemory=true $CLASS "$@"
    --- End diff --
    
    MaxDirectMemorySize is definitely not needed it just sets a limit for direct memory otherwise it will take as much as there is heap space. The Xmx/n is a problem for large clusters but what default value should we set? I can add a crail-env.sh to set these values, but by default I still would not set anything. I can add a warning in the script that suggests setting these values (given the user has lots of memory).


---

[GitHub] incubator-crail pull request #26: Start script: remove heap size argument

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-crail/pull/26


---

[GitHub] incubator-crail pull request #26: Start script: remove heap size argument

Posted by patrickstuedi <gi...@git.apache.org>.

Github user patrickstuedi commented on a diff in the pull request:

    https://github.com/apache/incubator-crail/pull/26#discussion_r196787934
  
    --- Diff: bin/crail ---
    @@ -70,4 +70,4 @@ fi
     export CLASSPATH="$bin"/../jars/*:"$bin"/../conf:.
     export LD_LIBRARY_PATH="$bin/../lib:$LD_LIBRARY_PATH"
     
    -exec "$JAVA" -Dproc_$COMMAND -XX:MaxDirectMemorySize=64G -Dsun.nio.PageAlignDirectMemory=true -Xmn16G $CLASS "$@"
    +exec "$JAVA" -Dproc_$COMMAND -Dsun.nio.PageAlignDirectMemory=true $CLASS "$@"
    --- End diff --
    
    Can we safely remove those parameters? What about MaxDirectMemorySize, do we need this to support large memory configurations? What about Xmn16G, is removing this not creating a performance problem for large memory configurations?


---