You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/09/05 14:56:55 UTC

[GitHub] [incubator-tuweni] atoulme opened a new pull request #148: Discv5 refactor

atoulme opened a new pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148


   <!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
   <!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
   
   ## PR description
   Refactoring of discv5 to simplify the code and handle handshakes separately from main traffic.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.88%`.
   > The diff coverage is `66.05%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.05%   -0.89%     
   + Complexity     4293     4133     -160     
   ============================================
     Files           401      373      -28     
     Lines         19867    19907      +40     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13149     -149     
   - Misses         5177     5375     +198     
   + Partials       1392     1383       -9     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.13% <44.25%> (+3.01%)` | `599.00 <23.00> (+3.00)` | |
   | #unit | `61.32% <59.75%> (-1.00%)` | `3842.00 <25.00> (-163.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-51.62%)` | `0.00 <0.00> (-9.00)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `81.57% <73.68%> (-3.13%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [25 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...4dc9d4a](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.88%`.
   > The diff coverage is `66.05%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.05%   -0.89%     
   + Complexity     4293     4133     -160     
   ============================================
     Files           401      373      -28     
     Lines         19867    19907      +40     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13149     -149     
   - Misses         5177     5375     +198     
   + Partials       1392     1383       -9     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.13% <44.25%> (+3.01%)` | `599.00 <23.00> (+3.00)` | |
   | #unit | `61.32% <59.75%> (-1.00%)` | `3842.00 <25.00> (-163.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-51.62%)` | `0.00 <0.00> (-9.00)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `81.57% <73.68%> (-3.13%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [25 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...b83aae6](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.81%`.
   > The diff coverage is `66.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.12%   -0.82%     
   + Complexity     4293     4128     -165     
   ============================================
     Files           401      373      -28     
     Lines         19867    19851      -16     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    13126     -172     
   - Misses         5177     5344     +167     
   + Partials       1392     1381      -11     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.09% <41.95%> (+2.96%)` | `601.00 <20.00> (+5.00)` | |
   | #unit | `61.38% <60.13%> (-0.93%)` | `3838.00 <20.00> (-167.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <50.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.04% <78.78%> (-0.67%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `62.55% <85.71%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `86.53% <86.53%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `87.12% <87.12%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...2adecc9](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `18.87%`.
   > The diff coverage is `41.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #148       +/-   ##
   =============================================
   - Coverage     66.93%   48.06%   -18.88%     
   + Complexity     4293      601     -3692     
   =============================================
     Files           401      134      -267     
     Lines         19867     5982    -13885     
     Branches       2450      582     -1868     
   =============================================
   - Hits          13298     2875    -10423     
   + Misses         5177     2855     -2322     
   + Partials       1392      252     -1140     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.06% <41.44%> (+2.93%)` | `601.00 <19.00> (+5.00)` | |
   | #unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `30.95% <0.00%> (-18.94%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `30.00% <0.00%> (-47.50%)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `0.00% <0.00%> (-62.56%)` | `0.00 <0.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `17.21% <17.21%> (ø)` | `0.00 <0.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `39.13% <25.00%> (-47.24%)` | `2.00 <0.00> (-8.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `40.42% <42.42%> (-44.29%)` | `8.00 <5.00> (+1.00)` | :arrow_down: |
   | [...n/kotlin/org/apache/tuweni/devp2p/v5/ENRStorage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRU5SU3RvcmFnZS5rdA==) | `66.66% <50.00%> (-33.34%)` | `0.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `80.76% <72.22%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [301 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...0c5f4e3](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.71%`.
   > The diff coverage is `67.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.22%   -0.72%     
   + Complexity     4293     4142     -151     
   ============================================
     Files           401      373      -28     
     Lines         19867    19889      +22     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13171     -127     
   - Misses         5177     5332     +155     
   + Partials       1392     1386       -6     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.40% <44.67%> (+3.27%)` | `604.00 <23.00> (+8.00)` | |
   | #unit | `61.49% <60.77%> (-0.83%)` | `3851.00 <25.00> (-154.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `50.11% <0.00%> (+0.22%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.21% <78.94%> (-0.50%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.82% <84.82%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [23 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...d42c048](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.63%`.
   > The diff coverage is `67.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.29%   -0.64%     
   + Complexity     4293     4146     -147     
   ============================================
     Files           401      372      -29     
     Lines         19867    19876       +9     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13177     -121     
   - Misses         5177     5314     +137     
   + Partials       1392     1385       -7     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.38% <44.67%> (+3.25%)` | `599.00 <23.00> (+3.00)` | |
   | #unit | `61.56% <60.77%> (-0.76%)` | `3855.00 <25.00> (-150.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.21% <78.94%> (-0.50%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.82% <84.82%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [19 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...5ce960e](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `5.43%`.
   > The diff coverage is `60.82%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   61.49%   -5.44%     
   + Complexity     4293     3854     -439     
   ============================================
     Files           401      348      -53     
     Lines         19867    19520     -347     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    12004    -1294     
   - Misses         5177     6231    +1054     
   + Partials       1392     1285     -107     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `61.49% <60.82%> (-0.83%)` | `3854.00 <25.00> (-151.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `47.66% <0.00%> (-2.23%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `72.50% <0.00%> (-5.00%)` | `0.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `0.00% <0.00%> (-64.71%)` | `0.00 <0.00> (-7.00)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `57.54% <57.54%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `81.57% <73.68%> (-3.13%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [90 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...b83aae6](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme merged pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.81%`.
   > The diff coverage is `66.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.12%   -0.82%     
   + Complexity     4293     4130     -163     
   ============================================
     Files           401      373      -28     
     Lines         19867    19855      -12     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    13129     -169     
   - Misses         5177     5344     +167     
   + Partials       1392     1382      -10     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.06% <41.44%> (+2.93%)` | `601.00 <19.00> (+5.00)` | |
   | #unit | `61.41% <59.96%> (-0.91%)` | `3840.00 <19.00> (-165.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.22% <0.00%> (-0.67%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <50.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.04% <78.78%> (-0.67%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `62.55% <85.71%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `86.40% <86.40%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `87.12% <87.12%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...0c5f4e3](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `5.36%`.
   > The diff coverage is `60.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   61.56%   -5.37%     
   + Complexity     4293     3855     -438     
   ============================================
     Files           401      347      -54     
     Lines         19867    19496     -371     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    12003    -1295     
   - Misses         5177     6205    +1028     
   + Partials       1392     1288     -104     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `61.56% <60.77%> (-0.76%)` | `3855.00 <25.00> (-150.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `47.43% <0.00%> (-2.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `72.50% <0.00%> (-5.00%)` | `0.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `0.00% <0.00%> (-64.71%)` | `0.00 <0.00> (-7.00)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `57.54% <57.54%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.21% <78.94%> (-0.50%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | ... and [87 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...5ce960e](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme merged pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.81%`.
   > The diff coverage is `66.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.12%   -0.82%     
   + Complexity     4293     4128     -165     
   ============================================
     Files           401      373      -28     
     Lines         19867    19851      -16     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    13126     -172     
   - Misses         5177     5344     +167     
   + Partials       1392     1381      -11     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.09% <41.95%> (+2.96%)` | `601.00 <20.00> (+5.00)` | |
   | #unit | `61.38% <60.13%> (-0.93%)` | `3838.00 <20.00> (-167.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <50.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.04% <78.78%> (-0.67%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `62.55% <85.71%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `86.53% <86.53%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `87.12% <87.12%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...769e2ef](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `18.79%`.
   > The diff coverage is `44.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #148       +/-   ##
   =============================================
   - Coverage     66.93%   48.13%   -18.80%     
   + Complexity     4293      599     -3694     
   =============================================
     Files           401      134      -267     
     Lines         19867     6018    -13849     
     Branches       2450      586     -1864     
   =============================================
   - Hits          13298     2897    -10401     
   + Misses         5177     2866     -2311     
   + Partials       1392      255     -1137     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.13% <44.25%> (+3.01%)` | `599.00 <23.00> (+3.00)` | |
   | #unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `30.95% <0.00%> (-18.94%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `30.00% <0.00%> (-47.50%)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-51.62%)` | `0.00 <0.00> (-9.00)` | |
   | [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `15.15% <0.00%> (-69.70%)` | `2.00 <0.00> (-12.00)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `0.00% <0.00%> (-62.56%)` | `0.00 <0.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `16.99% <16.99%> (ø)` | `0.00 <0.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `39.13% <20.00%> (-47.24%)` | `2.00 <0.00> (-8.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `52.63% <45.61%> (-32.08%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | ... and [302 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...4dc9d4a](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `18.53%`.
   > The diff coverage is `44.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #148       +/-   ##
   =============================================
   - Coverage     66.93%   48.40%   -18.54%     
   + Complexity     4293      604     -3689     
   =============================================
     Files           401      134      -267     
     Lines         19867     6000    -13867     
     Branches       2450      586     -1864     
   =============================================
   - Hits          13298     2904    -10394     
   + Misses         5177     2846     -2331     
   + Partials       1392      250     -1142     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.40% <44.67%> (+3.27%)` | `604.00 <23.00> (+8.00)` | |
   | #unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `30.95% <0.00%> (-18.94%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `30.00% <0.00%> (-47.50%)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/topic/Ticket.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVGlja2V0Lmt0) | `0.00% <0.00%> (-51.62%)` | `0.00 <0.00> (-9.00)` | |
   | [...in/org/apache/tuweni/devp2p/v5/topic/TopicTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvdG9waWMvVG9waWNUYWJsZS5rdA==) | `15.15% <0.00%> (-69.70%)` | `2.00 <0.00> (-12.00)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `0.00% <0.00%> (-62.56%)` | `0.00 <0.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...ain/kotlin/org/apache/tuweni/devp2p/v5/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZXMua3Q=) | `18.30% <18.30%> (ø)` | `0.00 <0.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `39.13% <20.00%> (-47.24%)` | `2.00 <0.00> (-8.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `52.63% <45.61%> (-32.08%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | ... and [302 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...d42c048](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.81%`.
   > The diff coverage is `66.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.12%   -0.82%     
   + Complexity     4293     4128     -165     
   ============================================
     Files           401      373      -28     
     Lines         19867    19851      -16     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    13126     -172     
   - Misses         5177     5344     +167     
   + Partials       1392     1381      -11     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.09% <41.95%> (+2.96%)` | `601.00 <20.00> (+5.00)` | |
   | #unit | `61.38% <60.13%> (-0.93%)` | `3838.00 <20.00> (-167.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <50.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.04% <78.78%> (-0.67%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `62.55% <85.71%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `86.53% <86.53%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `87.12% <87.12%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...4dc9d4a](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.71%`.
   > The diff coverage is `67.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.22%   -0.72%     
   + Complexity     4293     4145     -148     
   ============================================
     Files           401      373      -28     
     Lines         19867    19900      +33     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13178     -120     
   - Misses         5177     5340     +163     
   + Partials       1392     1382      -10     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.22% <43.90%> (+3.09%)` | `600.00 <23.00> (+4.00)` | |
   | #unit | `61.49% <60.82%> (-0.83%)` | `3854.00 <25.00> (-151.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.66% <0.00%> (-0.23%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `81.57% <73.68%> (-3.13%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.82% <84.82%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [22 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...d42c048](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.71%`.
   > The diff coverage is `67.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.22%   -0.72%     
   + Complexity     4293     4145     -148     
   ============================================
     Files           401      373      -28     
     Lines         19867    19900      +33     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13178     -120     
   - Misses         5177     5340     +163     
   + Partials       1392     1382      -10     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.22% <43.90%> (+3.09%)` | `600.00 <23.00> (+4.00)` | |
   | #unit | `61.49% <60.82%> (-0.83%)` | `3854.00 <25.00> (-151.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.66% <0.00%> (-0.23%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `81.57% <73.68%> (-3.13%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.82% <84.82%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [22 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...b83aae6](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.81%`.
   > The diff coverage is `66.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.12%   -0.82%     
   + Complexity     4293     4128     -165     
   ============================================
     Files           401      373      -28     
     Lines         19867    19851      -16     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    13126     -172     
   - Misses         5177     5344     +167     
   + Partials       1392     1381      -11     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.09% <41.95%> (+2.96%)` | `601.00 <20.00> (+5.00)` | |
   | #unit | `61.38% <60.13%> (-0.93%)` | `3838.00 <20.00> (-167.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.44% <0.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <50.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.04% <78.78%> (-0.67%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `62.55% <85.71%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `86.53% <86.53%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `87.12% <87.12%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...cccd25f](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.81%`.
   > The diff coverage is `66.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.12%   -0.82%     
   + Complexity     4293     4130     -163     
   ============================================
     Files           401      373      -28     
     Lines         19867    19855      -12     
     Branches       2450     2443       -7     
   ============================================
   - Hits          13298    13129     -169     
   - Misses         5177     5344     +167     
   + Partials       1392     1382      -10     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.06% <41.44%> (+2.93%)` | `601.00 <19.00> (+5.00)` | |
   | #unit | `61.41% <59.96%> (-0.91%)` | `3840.00 <19.00> (-165.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.22% <0.00%> (-0.67%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.00% <5.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <50.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.04% <78.78%> (-0.67%)` | `11.00 <5.00> (+4.00)` | :arrow_down: |
   | [.../apache/tuweni/net/coroutines/CoroutineSelector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlbGVjdG9yLmt0) | `62.55% <85.71%> (ø)` | `2.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `86.40% <86.40%> (ø)` | `0.00 <0.00> (?)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `87.12% <87.12%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...769e2ef](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #148: Discv5 refactor

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #148:
URL: https://github.com/apache/incubator-tuweni/pull/148#issuecomment-687920918


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=h1) Report
   > Merging [#148](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3c87d384a0eefe21a49bd6d6ff51d03deedf92d5?el=desc) will **decrease** coverage by `0.71%`.
   > The diff coverage is `67.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #148      +/-   ##
   ============================================
   - Coverage     66.93%   66.22%   -0.72%     
   + Complexity     4293     4142     -151     
   ============================================
     Files           401      373      -28     
     Lines         19867    19889      +22     
     Branches       2450     2448       -2     
   ============================================
   - Hits          13298    13171     -127     
   - Misses         5177     5332     +155     
   + Partials       1392     1386       -6     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `48.40% <44.67%> (+3.27%)` | `604.00 <23.00> (+8.00)` | |
   | #unit | `61.49% <60.77%> (-0.83%)` | `3851.00 <25.00> (-154.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/src/main/java/org/apache/tuweni/bytes/Bytes.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlcy5qYXZh) | `79.66% <0.00%> (-2.24%)` | `151.00 <0.00> (ø)` | |
   | [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `73.27% <0.00%> (-0.91%)` | `19.00 <0.00> (ø)` | |
   | [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `50.11% <0.00%> (+0.22%)` | `0.00 <0.00> (ø)` | |
   | [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `77.50% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/kotlin/org/apache/tuweni/ethclient/DNSClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0ROU0NsaWVudC5rdA==) | `64.70% <0.00%> (ø)` | `7.00 <0.00> (ø)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `5.07% <5.07%> (ø)` | `3.00 <3.00> (?)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `73.91% <40.00%> (-12.46%)` | `8.00 <2.00> (-2.00)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Message.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvTWVzc2FnZS5rdA==) | `84.61% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `84.21% <78.94%> (-0.50%)` | `15.00 <8.00> (+8.00)` | :arrow_down: |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.82% <84.82%> (ø)` | `11.00 <11.00> (?)` | |
   | ... and [23 more](https://codecov.io/gh/apache/incubator-tuweni/pull/148/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=footer). Last update [3c87d38...5ce960e](https://codecov.io/gh/apache/incubator-tuweni/pull/148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org