[jira] [Commented] (SSHD-580) getInvertedIn.close() does not close stdin of remote program

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853155#comment-15853155 ] 

ASF GitHub Bot commented on SSHD-580:
-------------------------------------

Github user volth closed the pull request at:

    https://github.com/apache/mina-sshd/pull/14


> getInvertedIn.close() does not close stdin of remote program
> ------------------------------------------------------------
>
>                 Key: SSHD-580
>                 URL: https://issues.apache.org/jira/browse/SSHD-580
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Volth
>            Assignee: Goldstein Lyor
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: AbstractClientChannel.diff, ChannelOutputStream.diff
>
>
> {code:java}
> val channel = session.createExecChannel("cat /dev/stdin")
> channel.setOut(new sshd.common.util.io.NoCloseOutputStream(System.out))
> channel.setErr(new sshd.common.util.io.NoCloseOutputStream(System.err))
> channel.open().verify()
> val out = channel.getInvertedIn
> out.write("lala\nla".getBytes)
> out.close()
> channel.waitFor(sshd.client.channel.ClientChannel.ClientChannelEvent.CLOSED :: Nil, 0)
> {code}
> I expect that out.close() would close stdin of remote program and such process as "cat /dev/stdin" would terminate after reading stdin to the end.
> It works well when the pumping thread is in action:
> {code:java}
> val channel = session.createExecChannel("cat /dev/stdin")
> channel.setOut(new sshd.common.util.io.NoCloseOutputStream(System.out))
> channel.setErr(new sshd.common.util.io.NoCloseOutputStream(System.err))
> channel.setIn(new ByteArrayInputStream("lala\nla".getBytes))
> channel.open().verify()
> channel.waitFor(sshd.client.channel.ClientChannel.ClientChannelEvent.CLOSED :: Nil, 0)
> {code}
> The pumping thread sends SSH_MSG_CHANNEL_EOF message at the end of the data.
> invertedIn.close() does not.
> Tested agains git "master" and wide range of remote ssh-servers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)