You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Shalitha Suranga <sh...@gmail.com> on 2018/10/19 06:18:01 UTC
[allura:tickets] #7459 Show password requirements on forms
---
** [tickets:#7459] Show password requirements on forms**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 18, 2018 05:10 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Shalitha Suranga <sh...@gmail.com>.
- **status**: open --> in-progress
---
** [tickets:#7459] Show password requirements on forms**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 18, 2018 05:10 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Dave Brondsema <da...@brondsema.net>.
`forge_form.html` is very generic and ends up used in lots of places, so I would prefer doing it only for the `PasswordChangeBase`/`PasswordChangeForm` and `RegistrationForm` forms that need it. And now that I think about it, I think browser validation can do a lot of this for us. `minlength` and `maxlength` attributes can be set on the input fields. To do this with easywidgets `PasswordField` I believe something like this should work:
```
ew.PasswordField(
name='pw',
label='New Password',
...
attrs=dict(minlength=6, maxlength=30),
...
```
Of course that's hardcoded numbers, that would change of course.
Then the browser will do the enforcing when they hit submit. If we want to enforce it even sooner, we could try adding JS to call `checkValidity` or `reportValidity` on the fields whenever they change.
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Wed Oct 17, 2018 05:19 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Dave Brondsema <da...@brondsema.net>.
Also checking that the new passwords match each other would be nice.
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Tue Oct 16, 2018 04:18 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Shalitha Suranga <sh...@gmail.com>.
This is implemented as backend validation. when I enter few chars in register form I got error message "Enter a value 6 characters long or more". But user need to click register button to see how many chars required minimum. You mean we can display before that ? maybe when user focuses password-field like real time validation
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Tue Mar 31, 2015 06:14 AM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: Ticket 7459 discussion
Posted by Dave Brondsema <da...@brondsema.net>.
Native browser validations on submit is a good first step, at least they dont' have to submit the form then :)
I would say try using checkValidity or reportValidity whenever the password field changes, that will run the browser's own validation again (before submit). That would be nice, but I suspect that in some browsers it might interfere with the user typing. If that happens, then I would suggest displaying our own message right next to the input field, maybe using the "tooltip" javascript widget so it can point right at the field.
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 18, 2018 04:49 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: Ticket 7459 discussion
Posted by Shalitha Suranga <sh...@gmail.com>.
You mean native browser validation is simply okay or better to extend using `checkValidity` and `reportValidity` to display real time message when user is typing password?
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 18, 2018 04:47 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Shalitha Suranga <sh...@gmail.com>.
Yeah I checked `forge_form` is very generic that's why I told this is reusable ;) . Nice idea with html element default validation tricks. we will only do for password field then. Binding event with password field is okay I mentioned how we can display real-time message. What would you suggest where we can display real-time message?
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 18, 2018 02:48 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Dave Brondsema <da...@brondsema.net>.
Right. One simple option would be to show the requirement right away as plain text. JS realtime validation upon focus would be nice too.
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 11, 2018 08:13 AM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7459 Show password requirements on forms
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> closed
- **assigned_to**: Shalitha Suranga
- **Reviewer**: Dave Brondsema
- **Comment**:
Merged as part of https://forge-allura.apache.org/p/allura/git/merge-requests/301/
Thanks for this improvement
---
** [tickets:#7459] Show password requirements on forms**
**Status:** closed
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Fri Oct 19, 2018 06:18 AM UTC
**Owner:** Shalitha Suranga
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 7459 discussion
Posted by Shalitha Suranga <sh...@gmail.com>.
Hi.. Dave
We can easily add reusable message for real-time validation in forms by doing some modifications at `forge_form.html` as per below. And validation logic can be done as `extra_js` snippet maybe.
```python
<div class="grid-{{15 + extra_width}}">{{field.display(**ctx)}}
{% if field.real_valid %}
<span id="rw_{{field.name}}"></span>
{% endif %}
</div>
```
We set `real_valid=True` if we need to enable real time validation for a form widget
What would you suggest. going with something like this?
---
** [tickets:#7459] Show password requirements on forms**
**Status:** open
**Milestone:** unreleased
**Created:** Wed Jun 11, 2014 03:46 PM UTC by Dave Brondsema
**Last Updated:** Tue Oct 16, 2018 04:19 PM UTC
**Owner:** nobody
It would be helpful to show password requirements (aka min # of chars) on the password change form. And account creation.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.