You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/11/03 22:45:06 UTC

[GitHub] [maven-surefire] Col-E opened a new pull request #252: Support @ParameterizedTest for JUnit 5 test reruns

Col-E opened a new pull request #252: Support @ParameterizedTest for JUnit 5 test reruns
URL: https://github.com/apache/maven-surefire/pull/252
 
 
   This change fixes the issue discussed in #245 where `@ParameterizedTest` were not supported by the JUnitPlatformProvider.
   
   The fix is rather simple, moving from `DiscoverySelectors.selectMethod` to `DiscoverySelectors.selectUniqueId`. Included are additions to `JUnitPlatformProviderTest` showing this feature is now supported. 
   
   I have detailed why this is a good alternative to parsing the legacy name in a gist: ["The case for UniqueId over Legacy Name "](https://gist.github.com/Col-E/47e0d7cd7267965dada899d4d5e11888)
   
   As mentioned in the gist, using `selectUniqueId` allows us to undo the changes made to [`RunListenerAdapter.toClassMethodName`](https://github.com/apache/maven-surefire/pull/245/files#diff-ad07b0c74885ecb3d687dcc85495e390R240) that were made in #245, which I've also included in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services