You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by wl...@apache.org on 2024/02/12 19:14:13 UTC
(gobblin) branch master updated: [GOBBLIN-2001] Add configuration to disable task failed event from emitting (#3877)
This is an automated email from the ASF dual-hosted git repository.
wlo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git
The following commit(s) were added to refs/heads/master by this push:
new 75d9336f0 [GOBBLIN-2001] Add configuration to disable task failed event from emitting (#3877)
75d9336f0 is described below
commit 75d9336f0fe4f8e564c32c6440a343ac66bba183
Author: William Lo <lo...@gmail.com>
AuthorDate: Mon Feb 12 14:14:08 2024 -0500
[GOBBLIN-2001] Add configuration to disable task failed event from emitting (#3877)
Add configuration to disable task failed event from emitting
---
.../src/main/java/org/apache/gobblin/runtime/Task.java | 13 ++++++++-----
.../org/apache/gobblin/runtime/TaskConfigurationKeys.java | 6 +++++-
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/Task.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/Task.java
index 9c01964ca..7c315e307 100644
--- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/Task.java
+++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/Task.java
@@ -574,11 +574,14 @@ public class Task implements TaskIFace {
.setProp(ConfigurationKeys.TASK_FAILURE_EXCEPTION_KEY, Throwables.getStackTraceAsString(cleanedException));
// Send task failure event
- FailureEventBuilder failureEvent = new FailureEventBuilder(FAILED_TASK_EVENT);
- failureEvent.setRootCause(cleanedException);
- failureEvent.addMetadata(TASK_STATE, this.taskState.toString());
- failureEvent.addAdditionalMetadata(this.taskEventMetadataGenerator.getMetadata(this.taskState, failureEvent.getName()));
- failureEvent.submit(taskContext.getTaskMetrics().getMetricContext());
+ if (!this.taskState.getPropAsBoolean(TaskConfigurationKeys.TASK_DISABLE_FAILED_EVENTS,
+ TaskConfigurationKeys.DEFAULT_TASK_DISABLE_FAILED_EVENTS)) {
+ FailureEventBuilder failureEvent = new FailureEventBuilder(FAILED_TASK_EVENT);
+ failureEvent.setRootCause(cleanedException);
+ failureEvent.addMetadata(TASK_STATE, this.taskState.toString());
+ failureEvent.addAdditionalMetadata(this.taskEventMetadataGenerator.getMetadata(this.taskState, failureEvent.getName()));
+ failureEvent.submit(taskContext.getTaskMetrics().getMetricContext());
+ }
}
/**
diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskConfigurationKeys.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskConfigurationKeys.java
index 958dfe298..6aa797a10 100644
--- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskConfigurationKeys.java
+++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskConfigurationKeys.java
@@ -35,7 +35,11 @@ public class TaskConfigurationKeys {
public static final String TASK_IS_SINGLE_BRANCH_SYNCHRONOUS = "gobblin.task.is.single.branch.synchronous";
public static final String DEFAULT_TASK_IS_SINGLE_BRANCH_SYNCHRONOUS = Boolean.toString(false);
-
public static final String TASK_SKIP_ERROR_RECORDS = "task.skip.error.records";
public static final long DEFAULT_TASK_SKIP_ERROR_RECORDS = 0;
+
+ public static final String TASK_DISABLE_FAILED_EVENTS = "gobblin.task.disable.failed.event.emission";
+
+ public static final boolean DEFAULT_TASK_DISABLE_FAILED_EVENTS = false;
+
}