You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/16 14:50:50 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
kgabryje opened a new pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303
### SUMMARY
When the tab bar in SqlLab were overflown, the tabs shown in dropdown were justified to center instead of left.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/migrations/versions/1d9e835a84f9\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZDllODM1YTg0ZjlfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `91.48% <0.00%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.00% <0.00%> (ø)` | |
| [...ersions/2929af7925ed\_tz\_offsets\_in\_data\_sources.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yOTI5YWY3OTI1ZWRfdHpfb2Zmc2V0c19pbl9kYXRhX3NvdXJjZXMucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `82.75% <0.00%> (ø)` | |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...rations/versions/7dbf98566af7\_slice\_description.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZGJmOTg1NjZhZjdfc2xpY2VfZGVzY3JpcHRpb24ucHk=) | `0.00% <0.00%> (ø)` | |
| [...versions/0b1f1ab473c0\_add\_extra\_column\_to\_query.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8wYjFmMWFiNDczYzBfYWRkX2V4dHJhX2NvbHVtbl90b19xdWVyeS5weQ==) | `0.00% <0.00%> (ø)` | |
| [...ns/versions/620241d1153f\_update\_time\_grain\_sqla.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82MjAyNDFkMTE1M2ZfdXBkYXRlX3RpbWVfZ3JhaW5fc3FsYS5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/migrations/versions/ef8843b41dac\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lZjg4NDNiNDFkYWNfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/cachekeys/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2FjaGVrZXlzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | `80.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `83.33% <0.00%> (ø)` | |
| [...igrations/versions/ad82a75afd82\_add\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZDgyYTc1YWZkODJfYWRkX3F1ZXJ5X21vZGVsLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.64% <0.00%> (ø)` | |
| [superset/migrations/versions/c829ff0b37d0\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jODI5ZmYwYjM3ZDBfLnB5) | `0.00% <0.00%> (ø)` | |
| [...ons/bebcf3fed1fe\_convert\_dashboard\_v1\_positions.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iZWJjZjNmZWQxZmVfY29udmVydF9kYXNoYm9hcmRfdjFfcG9zaXRpb25zLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/log/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `1.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.38% -1.34%
==========================================
Files 441 834 +393
Lines 14721 39562 +24841
Branches 3610 3610
==========================================
+ Hits 9233 24286 +15053
- Misses 5307 15095 +9788
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `60.59% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
| [...ons/a33a03f16c4a\_add\_extra\_column\_to\_savedquery.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hMzNhMDNmMTZjNGFfYWRkX2V4dHJhX2NvbHVtbl90b19zYXZlZHF1ZXJ5LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/migrations/versions/d39b1e37131d\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kMzliMWUzNzEzMWRfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <0.00%> (ø)` | |
| [...ations/versions/130915240929\_is\_sqllab\_viz\_flow.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xMzA5MTUyNDA5MjlfaXNfc3FsbGFiX3Zpel9mbG93LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset/utils/urls.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvdXJscy5weQ==) | `100.00% <0.00%> (ø)` | |
| [.../versions/3325d4caccc8\_dashboard\_scoped\_filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zMzI1ZDRjYWNjYzhfZGFzaGJvYXJkX3Njb3BlZF9maWx0ZXJzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/migrations/versions/1e2841a4128\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZTI4NDFhNDEyOF8ucHk=) | `0.00% <0.00%> (ø)` | |
| ... and [384 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <0.00%> (ø)` | |
| [superset/connectors/sqla/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [...ns/a65458420354\_add\_result\_backend\_time\_logging.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hNjU0NTg0MjAzNTRfYWRkX3Jlc3VsdF9iYWNrZW5kX3RpbWVfbG9nZ2luZy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/migrations/versions/4736ec66ce19\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NzM2ZWM2NmNlMTlfLnB5) | `0.00% <0.00%> (ø)` | |
| [.../migrations/versions/c617da68de7d\_form\_nullable.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jNjE3ZGE2OGRlN2RfZm9ybV9udWxsYWJsZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | `79.16% <0.00%> (ø)` | |
| [...df208545\_migrate\_time\_range\_for\_default\_filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Y2U4ZGYyMDg1NDVfbWlncmF0ZV90aW1lX3JhbmdlX2Zvcl9kZWZhdWx0X2ZpbHRlcnMucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/commands/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvYmFzZS5weQ==) | `100.00% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `1.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.38% -1.34%
==========================================
Files 441 834 +393
Lines 14721 39562 +24841
Branches 3610 3610
==========================================
+ Hits 9233 24286 +15053
- Misses 5307 15095 +9788
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `60.59% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [...ions/versions/7e3ddad2a00b\_results\_key\_to\_query.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZTNkZGFkMmEwMGJfcmVzdWx0c19rZXlfdG9fcXVlcnkucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.52% <0.00%> (ø)` | |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `89.47% <0.00%> (ø)` | |
| [superset/migrations/env.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9lbnYucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `86.80% <0.00%> (ø)` | |
| [...versions/0c5070e96b57\_add\_user\_attributes\_table.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8wYzUwNzBlOTZiNTdfYWRkX3VzZXJfYXR0cmlidXRlc190YWJsZS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `94.38% <0.00%> (ø)` | |
| [...et/migrations/versions/ddd6ebdd853b\_annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kZGQ2ZWJkZDg1M2JfYW5ub3RhdGlvbnMucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `85.71% <0.00%> (ø)` | |
| ... and [384 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710094044
@rusackas Can we do a quick merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `65.82% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | `87.50% <0.00%> (ø)` | |
| [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/migrations/versions/6414e83d82b7\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82NDE0ZTgzZDgyYjdfLnB5) | `0.00% <0.00%> (ø)` | |
| [.../c2acd2cf3df2\_alter\_type\_of\_dbs\_encrypted\_extra.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jMmFjZDJjZjNkZjJfYWx0ZXJfdHlwZV9vZl9kYnNfZW5jcnlwdGVkX2V4dHJhLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `88.67% <0.00%> (ø)` | |
| [superset/sql\_validators/presto\_db.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcHJlc3RvX2RiLnB5) | `82.89% <0.00%> (ø)` | |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/gsheets.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2dzaGVldHMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [...ns/versions/620241d1153f\_update\_time\_grain\_sqla.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82MjAyNDFkMTE1M2ZfdXBkYXRlX3RpbWVfZ3JhaW5fc3FsYS5weQ==) | `0.00% <0.00%> (ø)` | |
| [...ersions/732f1c06bcbf\_add\_fetch\_values\_predicate.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83MzJmMWMwNmJjYmZfYWRkX2ZldGNoX3ZhbHVlc19wcmVkaWNhdGUucHk=) | `0.00% <0.00%> (ø)` | |
| [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.31% <0.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.87% <0.00%> (ø)` | |
| [superset/migrations/versions/4e6a06bad7a8\_init.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80ZTZhMDZiYWQ3YThfaW5pdC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | `100.00% <0.00%> (ø)` | |
| [...rsions/a9c47e2c1547\_add\_impersonate\_user\_to\_dbs.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hOWM0N2UyYzE1NDdfYWRkX2ltcGVyc29uYXRlX3VzZXJfdG9fZGJzLnB5) | `0.00% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `2.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 60.53% -2.19%
==========================================
Files 441 393 -48
Lines 14721 24841 +10120
Branches 3610 0 -3610
==========================================
+ Hits 9233 15038 +5805
- Misses 5307 9803 +4496
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.53% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/dashboard/util/componentTypes.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLnRz) | | |
| [...perset-frontend/src/utils/DebouncedMessageQueue.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL0RlYm91bmNlZE1lc3NhZ2VRdWV1ZS5qcw==) | | |
| [...ntend/src/components/dataViewCommon/Pagination.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vUGFnaW5hdGlvbi50c3g=) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | | |
| [...-frontend/src/SqlLab/reducers/localStorageUsage.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9sb2NhbFN0b3JhZ2VVc2FnZS5qcw==) | | |
| [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | | |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | | |
| [superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLnRzeA==) | | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| ... and [823 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **increase** coverage by `2.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
+ Coverage 62.71% 65.68% +2.96%
==========================================
Files 441 835 +394
Lines 14721 40068 +25347
Branches 3610 3657 +47
==========================================
+ Hits 9233 26318 +17085
- Misses 5307 13637 +8330
+ Partials 181 113 -68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.29% <ø> (?)` | |
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <ø> (+3.87%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `85.71% <0.00%> (ø)` | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `79.48% <0.00%> (ø)` | |
| [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | `53.84% <0.00%> (ø)` | |
| ... and [559 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | `87.50% <0.00%> (ø)` | |
| [...tions/versions/e9df189e5c7e\_update\_base\_metrics.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOWRmMTg5ZTVjN2VfdXBkYXRlX2Jhc2VfbWV0cmljcy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...80aa3f04bc82\_add\_parent\_ids\_in\_dashboard\_layout.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MGFhM2YwNGJjODJfYWRkX3BhcmVudF9pZHNfaW5fZGFzaGJvYXJkX2xheW91dC5weQ==) | `0.00% <0.00%> (ø)` | |
| [...ions/versions/a2d606a761d9\_adding\_favstar\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hMmQ2MDZhNzYxZDlfYWRkaW5nX2ZhdnN0YXJfbW9kZWwucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.83% <0.00%> (ø)` | |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.12% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710094044
@rusackas @mistercrunch Can we do a quick merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `1.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.38% -1.34%
==========================================
Files 441 834 +393
Lines 14721 39562 +24841
Branches 3610 3610
==========================================
+ Hits 9233 24286 +15053
- Misses 5307 15095 +9788
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `60.59% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.36% <0.00%> (ø)` | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.71% <0.00%> (ø)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `93.44% <0.00%> (ø)` | |
| [.../migrations/versions/525c854f0005\_log\_this\_plus.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81MjVjODU0ZjAwMDVfbG9nX3RoaXNfcGx1cy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...rsions/289ce07647b\_add\_encrypted\_password\_field.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yODljZTA3NjQ3Yl9hZGRfZW5jcnlwdGVkX3Bhc3N3b3JkX2ZpZWxkLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [...d7c1a0d6f2da\_remove\_limit\_used\_from\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kN2MxYTBkNmYyZGFfcmVtb3ZlX2xpbWl0X3VzZWRfZnJvbV9xdWVyeV9tb2RlbC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/migrations/versions/5ccf602336a0\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81Y2NmNjAyMzM2YTBfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `88.67% <0.00%> (ø)` | |
| ... and [384 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `1.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.50% -1.22%
==========================================
Files 441 834 +393
Lines 14721 39562 +24841
Branches 3610 3610
==========================================
+ Hits 9233 24331 +15098
- Misses 5307 15050 +9743
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `60.77% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [.../versions/6c7537a6004a\_models\_for\_email\_reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82Yzc1MzdhNjAwNGFfbW9kZWxzX2Zvcl9lbWFpbF9yZXBvcnRzLnB5) | `0.00% <0.00%> (ø)` | |
| [...ations/versions/130915240929\_is\_sqllab\_viz\_flow.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xMzA5MTUyNDA5MjlfaXNfc3FsbGFiX3Zpel9mbG93LnB5) | `0.00% <0.00%> (ø)` | |
| [...ersions/def97f26fdfb\_add\_index\_to\_tagged\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kZWY5N2YyNmZkZmJfYWRkX2luZGV4X3RvX3RhZ2dlZF9vYmplY3QucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | `81.48% <0.00%> (ø)` | |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `87.87% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `96.29% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/tasks/slack\_util.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2xhY2tfdXRpbC5weQ==) | `89.47% <0.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <0.00%> (ø)` | |
| ... and [384 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mik-laj commented on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710685572
🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.80% -0.92%
==========================================
Files 441 835 +394
Lines 14721 39934 +25213
Branches 3610 3610
==========================================
+ Hits 9233 24683 +15450
- Misses 5307 15070 +9763
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [...rations/versions/7dbf98566af7\_slice\_description.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZGJmOTg1NjZhZjdfc2xpY2VfZGVzY3JpcHRpb24ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/migrations/versions/c9495751e314\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jOTQ5NTc1MWUzMTRfLnB5) | `0.00% <0.00%> (ø)` | |
| [...migrations/versions/ad4d656d92bc\_add\_avg\_metric.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZDRkNjU2ZDkyYmNfYWRkX2F2Z19tZXRyaWMucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.65% <0.00%> (ø)` | |
| [...8ee127d0d1d\_reconvert\_legacy\_filters\_into\_adhoc.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83OGVlMTI3ZDBkMWRfcmVjb252ZXJ0X2xlZ2FjeV9maWx0ZXJzX2ludG9fYWRob2MucHk=) | `0.00% <0.00%> (ø)` | |
| [...dding\_unique\_constraint\_on\_dashboard\_slices\_tbl.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xOTAxODg5Mzg1ODJfYWRkaW5nX3VuaXF1ZV9jb25zdHJhaW50X29uX2Rhc2hib2FyZF9zbGljZXNfdGJsLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.00% <0.00%> (ø)` | |
| [superset/translations/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | `87.50% <0.00%> (ø)` | |
| [superset/utils/feature\_flag\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZmVhdHVyZV9mbGFnX21hbmFnZXIucHk=) | `95.23% <0.00%> (ø)` | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `1.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 61.50% -1.22%
==========================================
Files 441 834 +393
Lines 14721 39562 +24841
Branches 3610 3610
==========================================
+ Hits 9233 24331 +15098
- Misses 5307 15050 +9743
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.71% <ø> (ø)` | |
| #python | `60.77% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.25% <ø> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `85.71% <0.00%> (ø)` | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `79.48% <0.00%> (ø)` | |
| [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | `53.84% <0.00%> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.00% <0.00%> (ø)` | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.71% <0.00%> (ø)` | |
| [superset/migrations/versions/ea033256294a\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lYTAzMzI1NjI5NGFfLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <0.00%> (ø)` | |
| ... and [384 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `2.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 60.59% -2.13%
==========================================
Files 441 393 -48
Lines 14721 24841 +10120
Branches 3610 0 -3610
==========================================
+ Hits 9233 15053 +5820
- Misses 5307 9788 +4481
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.59% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | | |
| [superset-frontend/src/components/Loading.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy50c3g=) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | | |
| [superset-frontend/src/components/FormLabel.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsLnRzeA==) | | |
| [...nents/gridComponents/new/DraggableNewComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9EcmFnZ2FibGVOZXdDb21wb25lbnQuanN4) | | |
| [superset-frontend/src/common/components/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRz) | | |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
| [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
| ... and [823 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 60.49% -2.23%
==========================================
Files 441 393 -48
Lines 14721 24841 +10120
Branches 3610 0 -3610
==========================================
+ Hits 9233 15027 +5794
- Misses 5307 9814 +4507
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.49% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
| [...perset-frontend/src/components/FilterBadgeIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyQmFkZ2VJY29uLmpzeA==) | | |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | | |
| [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS5qc3g=) | | |
| [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| ... and [823 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `2.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 60.59% -2.13%
==========================================
Files 441 393 -48
Lines 14721 24841 +10120
Branches 3610 0 -3610
==========================================
+ Hits 9233 15053 +5820
- Misses 5307 9788 +4481
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.59% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/dateFilterUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZGF0ZUZpbHRlclV0aWxzLnRz) | | |
| [...d/src/dashboard/util/getLeafComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExlYWZDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [superset-frontend/src/utils/reducerUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==) | | |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | | |
| [...erset-frontend/src/profile/components/UserInfo.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby50c3g=) | | |
| ... and [823 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **increase** coverage by `3.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
+ Coverage 62.71% 65.83% +3.11%
==========================================
Files 441 835 +394
Lines 14721 40068 +25347
Branches 3610 3657 +47
==========================================
+ Hits 9233 26377 +17144
- Misses 5307 13582 +8275
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.97% <ø> (?)` | |
| #javascript | `62.71% <ø> (ø)` | |
| #python | `61.27% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.29% <ø> (+9.03%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.36% <0.00%> (ø)` | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.71% <0.00%> (ø)` | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `93.44% <0.00%> (ø)` | |
| [.../migrations/versions/525c854f0005\_log\_this\_plus.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81MjVjODU0ZjAwMDVfbG9nX3RoaXNfcGx1cy5weQ==) | `0.00% <0.00%> (ø)` | |
| [...rsions/289ce07647b\_add\_encrypted\_password\_field.py](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yODljZTA3NjQ3Yl9hZGRfZW5jcnlwdGVkX3Bhc3N3b3JkX2ZpZWxkLnB5) | `0.00% <0.00%> (ø)` | |
| ... and [561 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `2.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 59.88% -2.84%
==========================================
Files 441 393 -48
Lines 14721 24839 +10118
Branches 3610 0 -3610
==========================================
+ Hits 9233 14875 +5642
- Misses 5307 9964 +4657
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.88% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | | |
| [.../src/dashboard/components/menu/WithPopoverMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvV2l0aFBvcG92ZXJNZW51LmpzeA==) | | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [superset-frontend/src/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvdXRpbHMuanM=) | | |
| [superset-frontend/src/components/ListView/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvaW5kZXgudHM=) | | |
| [superset-frontend/src/showSavedQuery/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L3V0aWxzLmpz) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | | |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | | |
| ... and [823 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11303: fix: Overflowing tab's styling in TabbedSqlEditors
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11303:
URL: https://github.com/apache/incubator-superset/pull/11303#issuecomment-710102936
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=h1) Report
> Merging [#11303](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9856f996206840469b10bff9192785b78ac16f91?el=desc) will **decrease** coverage by `2.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11303 +/- ##
==========================================
- Coverage 62.71% 60.59% -2.13%
==========================================
Files 441 393 -48
Lines 14721 24841 +10120
Branches 3610 0 -3610
==========================================
+ Hits 9233 15053 +5820
- Misses 5307 9788 +4481
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `60.59% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | | |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | | |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
| [superset-frontend/src/components/ModalTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyLmpzeA==) | | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | | |
| [superset-frontend/src/dashboard/util/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy50cw==) | | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| ... and [823 more](https://codecov.io/gh/apache/incubator-superset/pull/11303/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=footer). Last update [9856f99...b443c76](https://codecov.io/gh/apache/incubator-superset/pull/11303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org