[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #340: Cleanup Python and Ansible Code

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #340: Cleanup Python and Ansible Code
URL: https://github.com/apache/fluo-muchos/pull/340#discussion_r407808331
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -15,4 +15,11 @@
 language: python
 python:
   - "3.5"
-script: nosetests -w lib/
+install:
+  - pip install flake8
+  - pip install ansible-lint
+script:
+  - nosetests -w lib/
+  - ansible-lint -x 204,301
+  - flake8
+  - git ls-files | tr '\n' '\0' | xargs -0 -L1 bash -c 'if test "$(grep --files-with-matches --binary-files=without-match --max-count=1 --regexp='.*' "$0")" && test "$(tail --bytes=1 "$0")"; then echo "No new line at end of $0."; false; fi'
 
 Review comment:
   Can we put this last line into a script in `src/scripts/cibuild` or similar?
   
   Also, it might be better to put all these into a single script, and run them sequentially, because there's quite a bit of overhead in Travis CI to start separate tasks... compared to our expected run time for each of these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services