You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2011/06/01 15:21:56 UTC
DO NOT REPLY [Bug 51285] [PATCH] rotatelogs: Add -p option to call
arbitrary post-rotate program
https://issues.apache.org/bugzilla/show_bug.cgi?id=51285
--- Comment #4 from Joe Orton <jo...@redhat.com> 2011-06-01 13:21:56 UTC ---
Thanks for sending in the patch! I like the idea; I've had a requests for
similar "do X post-rotate" functionality so there is some kind of general need
here. A few comments:
a) What's the purpose of the double-forking and thread support?
apr_proc_create() will fork/exec internally, so why fork (/spawn thread) then
call apr_proc_create()?
b) Isn't the apr_tokenize_to_argv() usage going to split up any paths with
spaces in? it should be simple enough to set up argv[] correctly without
needing to flatten and reparse the string anyway.
c) probably should set the cmdtype to APR_PROGRAM_ENV to pass through any env
vars
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org