You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/09/18 12:40:00 UTC

[GitHub] flink pull request: [FLINK-2616] [test-stability] Hardens ZooKeepe...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1143

    [FLINK-2616] [test-stability] Hardens ZooKeeperLeaderElectionTest

    Replaces Curator's TestingCluster with TestingServer in ZooKeeperElection/RetrievalTests. This should be more lightweight. Increased the timeout to 200s in ZooKeeperLeaderElectionTest.
    
    Adds logging statements to ZooKeeperLeaderElection/RetrievalService.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixZooKeeperLeaderElectionTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1143
    
----
commit dd26ffc0688c89ec67ef738d050eb3311514d717
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-09-16T14:01:13Z

    [FLINK-2616] [test-stability] Replaces Curator's TestingCluster with TestingServer in ZooKeeperElection/RetrievalTests. Increased the timeout to 200s in ZooKeeperLeaderElectionTest.
    
    Adds logging statements to ZooKeeperLeaderElection/RetrievalService

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2616] [test-stability] Hardens ZooKeepe...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1143#issuecomment-141462318
  
    Changes look good. Good debug messages as well :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2616] [test-stability] Hardens ZooKeepe...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1143#issuecomment-141461360
  
    Let's merge this and see if it fixes the problem...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2616] [test-stability] Hardens ZooKeepe...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1143#issuecomment-141416101
  
    I really tried hard to reproduce the failing test case `ZooKeeperLeaderElectionTest.testMultipleLeaders` but it was really hard. I think the test case fails because of too much load on Travis. Therefore, I tried to reduce the resources used by the `ZooKeeperLeaderElectionTest` and increased the timeouts in order to mitigate the problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2616] [test-stability] Hardens ZooKeepe...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1143#issuecomment-141465883
  
    Hmm, it does not seem to solve the problem. I will further investigate the problem and reopen a PR which will hopefully fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2616] [test-stability] Hardens ZooKeepe...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:

    https://github.com/apache/flink/pull/1143


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---