You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2013/01/25 09:58:24 UTC
svn commit: r1438393 - in /maven/doxia/doxia-tools/trunk:
doxia-book-maven-plugin/src/main/java/org/apache/maven/doxia/plugin/
doxia-converter/src/main/java/org/apache/maven/doxia/
doxia-converter/src/main/java/org/apache/maven/doxia/cli/ doxia-convert...
Author: olamy
Date: Fri Jan 25 08:58:24 2013
New Revision: 1438393
URL: http://svn.apache.org/viewvc?rev=1438393&view=rev
Log:
use StringBuilder rather than StringBuffer
Modified:
maven/doxia/doxia-tools/trunk/doxia-book-maven-plugin/src/main/java/org/apache/maven/doxia/plugin/DoxiaRenderBooksMojo.java
maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/DefaultConverter.java
maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/cli/CLIManager.java
maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractFileWrapper.java
maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractWrapper.java
maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/HTTPLinkValidationResult.java
maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationResult.java
Modified: maven/doxia/doxia-tools/trunk/doxia-book-maven-plugin/src/main/java/org/apache/maven/doxia/plugin/DoxiaRenderBooksMojo.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-book-maven-plugin/src/main/java/org/apache/maven/doxia/plugin/DoxiaRenderBooksMojo.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-book-maven-plugin/src/main/java/org/apache/maven/doxia/plugin/DoxiaRenderBooksMojo.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-book-maven-plugin/src/main/java/org/apache/maven/doxia/plugin/DoxiaRenderBooksMojo.java Fri Jan 25 08:58:24 2013
@@ -281,7 +281,7 @@ public class DoxiaRenderBooksMojo
*/
private String formatResult( ValidationResult result )
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
if ( result.getErrors().size() > 0 )
{
Modified: maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/DefaultConverter.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/DefaultConverter.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/DefaultConverter.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/DefaultConverter.java Fri Jan 25 08:58:24 2013
@@ -577,7 +577,7 @@ public class DefaultConverter
IOUtil.close( is );
}
- StringBuffer msg = new StringBuffer();
+ StringBuilder msg = new StringBuilder();
msg.append( "Could not detect the encoding for file: " );
msg.append( f.getAbsolutePath() );
msg.append( "\n Specify explicitly the encoding." );
@@ -654,7 +654,7 @@ public class DefaultConverter
}
}
- StringBuffer msg = new StringBuffer();
+ StringBuilder msg = new StringBuilder();
msg.append( "Could not detect the Doxia format for file: " );
msg.append( f.getAbsolutePath() );
msg.append( "\n Specify explicitly the Doxia format." );
Modified: maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/cli/CLIManager.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/cli/CLIManager.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/cli/CLIManager.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/cli/CLIManager.java Fri Jan 25 08:58:24 2013
@@ -163,7 +163,7 @@ class CLIManager
{
List cleaned = new ArrayList();
- StringBuffer currentArg = null;
+ StringBuilder currentArg = null;
for ( int i = 0; i < args.length; i++ )
{
@@ -181,7 +181,7 @@ class CLIManager
}
// start building an argument here.
- currentArg = new StringBuffer( arg.substring( 1 ) );
+ currentArg = new StringBuilder( arg.substring( 1 ) );
addedToBuffer = true;
}
Modified: maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractFileWrapper.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractFileWrapper.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractFileWrapper.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractFileWrapper.java Fri Jan 25 08:58:24 2013
@@ -74,7 +74,7 @@ abstract class AbstractFileWrapper
if ( StringUtils.isNotEmpty( encoding ) && !encoding.equalsIgnoreCase( encoding )
&& !validateEncoding( encoding ) )
{
- StringBuffer msg = new StringBuffer();
+ StringBuilder msg = new StringBuilder();
msg.append( "The encoding '" + encoding + "' is not a valid one. The supported charsets are: " );
msg.append( StringUtils.join( CharsetDetector.getAllDetectableCharsets(), ", " ) );
throw new UnsupportedEncodingException( msg.toString() );
@@ -176,7 +176,7 @@ abstract class AbstractFileWrapper
/** {@inheritDoc} */
public java.lang.String toString()
{
- StringBuffer buf = new StringBuffer( super.toString() + "\n" );
+ StringBuilder buf = new StringBuilder( super.toString() + "\n" );
buf.append( "file= '" );
buf.append( getFile() + "'" );
return buf.toString();
Modified: maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractWrapper.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractWrapper.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractWrapper.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-converter/src/main/java/org/apache/maven/doxia/wrapper/AbstractWrapper.java Fri Jan 25 08:58:24 2013
@@ -117,7 +117,7 @@ abstract class AbstractWrapper
/** {@inheritDoc} */
public java.lang.String toString()
{
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
buf.append( "format = '" );
buf.append( getFormat() + "'" );
return buf.toString();
Modified: maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/HTTPLinkValidationResult.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/HTTPLinkValidationResult.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/HTTPLinkValidationResult.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/HTTPLinkValidationResult.java Fri Jan 25 08:58:24 2013
@@ -83,7 +83,7 @@ public class HTTPLinkValidationResult
/** {@inheritDoc} */
public String toString()
{
- StringBuffer sb = new StringBuffer( super.toString() );
+ StringBuilder sb = new StringBuilder( super.toString() );
sb.append( '\n' );
sb.append( "httpStatusCode=" ).append( this.httpStatusCode );
Modified: maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationResult.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationResult.java?rev=1438393&r1=1438392&r2=1438393&view=diff
==============================================================================
--- maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationResult.java (original)
+++ maven/doxia/doxia-tools/trunk/doxia-linkcheck/src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationResult.java Fri Jan 25 08:58:24 2013
@@ -96,7 +96,7 @@ public class LinkValidationResult
/** {@inheritDoc} */
public String toString()
{
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append( "persistent=" ).append( this.persistent ).append( '\n' );
sb.append( "status=" ).append( this.status ).append( '\n' );