You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/27 07:39:01 UTC

[GitHub] [skywalking] wallezhang opened a new issue #7815: [Feature] Add ClickHouse JDBC plugin

wallezhang opened a new issue #7815:
URL: https://github.com/apache/skywalking/issues/7815


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   ClickHouse® is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). This plugin will trace sql execution as other jdbc plugin.
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #7815: [Feature] Add ClickHouse JDBC plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #7815:
URL: https://github.com/apache/skywalking/issues/7815#issuecomment-928934446


   > Is HttpClient in sync or async? If it is in sync, it is easy. Adding an exit span to the JDBC implementation, than its exit span disappears automatically.
   
   It is in sync, I will try it. Thanks for reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #7815: [Feature] Add ClickHouse JDBC plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #7815:
URL: https://github.com/apache/skywalking/issues/7815#issuecomment-928927480






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7815: [Feature] Add ClickHouse JDBC plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7815:
URL: https://github.com/apache/skywalking/issues/7815#issuecomment-928931094


   Is HttpClient in sync or async? If it is in sync, it is easy. Adding an exit span to the JDBC implementation, than its exit span disappears automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7815: [Feature] Add ClickHouse JDBC plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7815:
URL: https://github.com/apache/skywalking/issues/7815#issuecomment-928931094


   Is HttpClient in sync or async? If it is in sync, it is easy. Adding an exit span to the JDBC implementation, than its exit span disappears automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #7815: [Feature] Add ClickHouse JDBC plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #7815:
URL: https://github.com/apache/skywalking/issues/7815#issuecomment-928927480


   Hi @kezhenxu94 ,
   
   I found that the JDBC driver of ClickHouse is implemented using HTTP protocol, so it will be handled by HTTPClient Plugin. And it can't be recognized as an db span through trace information. It looks like an ordinary http request, and the request path is always `/`, because of the sql is in the request body.
   
   This plugin will intercept JDBC methods and insert a correct db span, but there are still other wrong type spans produced by HttpClient plugin, how should I exclude these? Any ideas?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7815: [Feature] Add ClickHouse JDBC plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7815:
URL: https://github.com/apache/skywalking/issues/7815


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org