You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "arnaudbriche (via GitHub)" <gi...@apache.org> on 2025/04/06 16:10:00 UTC
[PR] Make CreateTableOpt public to ease creation of custom CatalogIO imple… [iceberg-go]
arnaudbriche opened a new pull request, #380:
URL: https://github.com/apache/iceberg-go/pull/380
…mentations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(catalog): Make CreateTableOpt public to ease creation of custom Catalog Impls [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #380:
URL: https://github.com/apache/iceberg-go/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Make CreateTableOpt public to ease creation of custom CatalogIO imple… [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #380:
URL: https://github.com/apache/iceberg-go/pull/380#discussion_r2031443143
##########
catalog/catalog.go:
##########
@@ -68,6 +67,13 @@ type PropertiesUpdateSummary struct {
Missing []string `json:"missing"`
}
+type CreateTableCfg struct {
Review Comment:
nit: can you just add a docstring comment on here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(catalog): Make CreateTableOpt public to ease creation of custom Catalog Impls [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #380:
URL: https://github.com/apache/iceberg-go/pull/380#discussion_r2031463740
##########
catalog/catalog.go:
##########
@@ -67,6 +67,7 @@ type PropertiesUpdateSummary struct {
Missing []string `json:"missing"`
}
+// Optional config of CreateTable operation
Review Comment:
please use the Godoc format, i.e. start with the object name:
```suggestion
// CreateTableCfg represents the configuration used for CreateTable operations
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org