You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jerrypeng (via GitHub)" <gi...@apache.org> on 2025/10/08 20:48:45 UTC
[PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
jerrypeng opened a new pull request, #52550:
URL: https://github.com/apache/spark/pull/52550
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add a new in memory sink called "ContinuousMemorySink" to facilitate RTM testing. This sink differentiates from the existing MemorySink by immediately sending output back to the driver once the output is generated and not just at the end of the batch which is what the current MemorySink does.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To facilitate RTM testing
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added simple test. There will be many RTM related tests that will be added in future PRs.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "jerrypeng (via GitHub)" <gi...@apache.org>.
jerrypeng commented on PR #52550:
URL: https://github.com/apache/spark/pull/52550#issuecomment-3402747137
thank you for merging @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "jerrypeng (via GitHub)" <gi...@apache.org>.
jerrypeng commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421526013
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemory.scala:
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import java.util
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.{SparkEnv, SparkUnsupportedOperationException}
+import org.apache.spark.rpc.{RpcEndpointRef, RpcEnv, ThreadSafeRpcEndpoint}
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
+import org.apache.spark.sql.connector.catalog.{SupportsWrite, TableCapability}
+import org.apache.spark.sql.connector.write.{
+ LogicalWriteInfo,
+ PhysicalWriteInfo,
+ Write,
+ WriteBuilder,
+ WriterCommitMessage
+}
+import org.apache.spark.sql.connector.write.streaming.{StreamingDataWriterFactory, StreamingWrite}
+import org.apache.spark.sql.internal.connector.SupportsStreamingUpdateAsAppend
+import org.apache.spark.sql.types.StructType
+
+/**
+ * A sink that stores the results in memory. This [[org.apache.spark.sql.execution.streaming.Sink]]
+ * is primarily intended for use in unit tests and does not provide durability.
+ * This is mostly copied from MemorySink, except that the data needs to be availalbe not in
+ * commit() but after each write.
+ */
+class ContinuousMemorySink
+ extends MemorySink
+ with SupportsWrite {
+
+ private val batches = new ArrayBuffer[Row]()
+ override def name(): String = "ContinuousMemorySink"
+
+ override def schema(): StructType = StructType(Nil)
+
+ override def capabilities(): util.Set[TableCapability] = {
+ util.EnumSet.of(TableCapability.STREAMING_WRITE)
+ }
+
+ override def newWriteBuilder(info: LogicalWriteInfo): WriteBuilder = {
+ new WriteBuilder with SupportsStreamingUpdateAsAppend {
+ private val inputSchema: StructType = info.schema()
+
+ override def build(): Write = {
+ new ContinuousMemoryWrite(batches, inputSchema)
+ }
+ }
+ }
+
+ /** Returns all rows that are stored in this [[Sink]]. */
+ override def allData: Seq[Row] = {
+ val batches = getBatches()
+ batches.synchronized {
+ batches.toSeq
+ }
+ }
+
+ override def latestBatchId: Option[Long] = {
+ None
+ }
+
+ override def latestBatchData: Seq[Row] = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "latestBatchData")
+ )
+ }
+
+ override def dataSinceBatch(sinceBatchId: Long): Seq[Row] = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "dataSinceBatch")
+ )
+ }
+
+ override def toDebugString: String = {
+ s"${allData}"
+ }
+
+ override def write(batchId: Long, needTruncate: Boolean, newRows: Array[Row]): Unit = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "write")
+ )
+ }
+
+ override def clear(): Unit = synchronized {
+ batches.clear()
+ }
+
+ private def getBatches(): ArrayBuffer[Row] = {
+ batches
+ }
+
+ override def toString(): String = "ContinuousMemorySink"
+}
+
+class ContinuousMemoryWrite(batches: ArrayBuffer[Row], schema: StructType) extends Write {
+ override def toStreaming: StreamingWrite = {
+ new ContinuousMemoryStreamingWrite(batches, schema)
+ }
+}
+
+/**
+ * An RPC endpoint that receives rows and stores them to the ArrayBuffer in real-time.
+ */
+class MemoryRealTimeRpcEndpoint(
+ override val rpcEnv: RpcEnv,
+ schema: StructType,
+ batches: ArrayBuffer[Row]
+) extends ThreadSafeRpcEndpoint {
+ private val encoder = ExpressionEncoder(schema).resolveAndBind().createDeserializer()
+
+ override def receive: PartialFunction[Any, Unit] = {
+ case rows: Array[InternalRow] =>
+ // synchronized block is optional here since ThreadSafeRpcEndpoint already, just to be safe
+ batches.synchronized {
+ rows.foreach { row =>
+ batches += encoder(row)
+ }
+ }
+ }
+}
+
+class ContinuousMemoryStreamingWrite(val batches: ArrayBuffer[Row], schema: StructType)
+ extends StreamingWrite {
+
+ private val memoryEndpoint =
+ new MemoryRealTimeRpcEndpoint(
+ SparkEnv.get.rpcEnv,
+ schema,
+ batches
+ )
+ @volatile private var endpointRef: RpcEndpointRef = _
+
+ override def createStreamingWriterFactory(info: PhysicalWriteInfo): StreamingDataWriterFactory = {
+ val endpointName = s"MemoryRealTimeRpcEndpoint-${java.util.UUID.randomUUID()}"
+ endpointRef = memoryEndpoint.rpcEnv.setupEndpoint(endpointName, memoryEndpoint)
+ RealTimeRowWriterFactory(endpointName, endpointRef.address)
+ }
+
+ override def useCommitCoordinator(): Boolean = false
+
+ override def commit(epochId: Long, messages: Array[WriterCommitMessage]): Unit = {
+ // We don't need to commit anything in this case, as the rows have already been printed
+ if (endpointRef != null) {
+ memoryEndpoint.rpcEnv.stop(endpointRef)
+ }
Review Comment:
yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2418743128
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemory.scala:
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import java.util
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.{SparkEnv, SparkUnsupportedOperationException}
+import org.apache.spark.rpc.{RpcEndpointRef, RpcEnv, ThreadSafeRpcEndpoint}
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
+import org.apache.spark.sql.connector.catalog.{SupportsWrite, TableCapability}
+import org.apache.spark.sql.connector.write.{
+ LogicalWriteInfo,
+ PhysicalWriteInfo,
+ Write,
+ WriteBuilder,
+ WriterCommitMessage
+}
+import org.apache.spark.sql.connector.write.streaming.{StreamingDataWriterFactory, StreamingWrite}
+import org.apache.spark.sql.internal.connector.SupportsStreamingUpdateAsAppend
+import org.apache.spark.sql.types.StructType
+
+/**
+ * A sink that stores the results in memory. This [[org.apache.spark.sql.execution.streaming.Sink]]
+ * is primarily intended for use in unit tests and does not provide durability.
+ * This is mostly copied from MemorySink, except that the data needs to be availalbe not in
Review Comment:
```suggestion
* This is mostly copied from MemorySink, except that the data needs to be available not in
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421376957
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RealTimeRowWriterFactory.scala:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import org.apache.spark.SparkEnv
+import org.apache.spark.rpc.RpcAddress
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.connector.write.{DataWriter, WriterCommitMessage}
+import org.apache.spark.sql.connector.write.streaming.StreamingDataWriterFactory
+import org.apache.spark.util.RpcUtils
+
+/**
+ * A [[StreamingDataWriterFactory]] that creates [[RealTimeRowWriter]], which sends rows to
+ * the driver in real-time through RPC.
+ *
+ * Note that, because it sends all rows to the driver, this factory will generally be unsuitable
+ * for production-quality sinks. It's intended for use in tests.
+ *
+ */
+case class RealTimeRowWriterFactory(
Review Comment:
I wonder why this doesn't follow the same naming pattern like `ContinuousMemoryRowWriterFactory`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421356932
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemory.scala:
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import java.util
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.{SparkEnv, SparkUnsupportedOperationException}
+import org.apache.spark.rpc.{RpcEndpointRef, RpcEnv, ThreadSafeRpcEndpoint}
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
+import org.apache.spark.sql.connector.catalog.{SupportsWrite, TableCapability}
+import org.apache.spark.sql.connector.write.{
+ LogicalWriteInfo,
+ PhysicalWriteInfo,
+ Write,
+ WriteBuilder,
+ WriterCommitMessage
+}
+import org.apache.spark.sql.connector.write.streaming.{StreamingDataWriterFactory, StreamingWrite}
+import org.apache.spark.sql.internal.connector.SupportsStreamingUpdateAsAppend
+import org.apache.spark.sql.types.StructType
+
+/**
+ * A sink that stores the results in memory. This [[org.apache.spark.sql.execution.streaming.Sink]]
+ * is primarily intended for use in unit tests and does not provide durability.
+ * This is mostly copied from MemorySink, except that the data needs to be availalbe not in
+ * commit() but after each write.
+ */
+class ContinuousMemorySink
+ extends MemorySink
+ with SupportsWrite {
+
+ private val batches = new ArrayBuffer[Row]()
+ override def name(): String = "ContinuousMemorySink"
+
+ override def schema(): StructType = StructType(Nil)
+
+ override def capabilities(): util.Set[TableCapability] = {
+ util.EnumSet.of(TableCapability.STREAMING_WRITE)
+ }
+
+ override def newWriteBuilder(info: LogicalWriteInfo): WriteBuilder = {
+ new WriteBuilder with SupportsStreamingUpdateAsAppend {
+ private val inputSchema: StructType = info.schema()
+
+ override def build(): Write = {
+ new ContinuousMemoryWrite(batches, inputSchema)
+ }
+ }
+ }
+
+ /** Returns all rows that are stored in this [[Sink]]. */
+ override def allData: Seq[Row] = {
+ val batches = getBatches()
+ batches.synchronized {
+ batches.toSeq
+ }
+ }
+
+ override def latestBatchId: Option[Long] = {
+ None
+ }
+
+ override def latestBatchData: Seq[Row] = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "latestBatchData")
+ )
+ }
+
+ override def dataSinceBatch(sinceBatchId: Long): Seq[Row] = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "dataSinceBatch")
+ )
+ }
+
+ override def toDebugString: String = {
+ s"${allData}"
+ }
+
+ override def write(batchId: Long, needTruncate: Boolean, newRows: Array[Row]): Unit = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "write")
+ )
+ }
+
+ override def clear(): Unit = synchronized {
+ batches.clear()
+ }
+
+ private def getBatches(): ArrayBuffer[Row] = {
+ batches
+ }
+
+ override def toString(): String = "ContinuousMemorySink"
+}
+
+class ContinuousMemoryWrite(batches: ArrayBuffer[Row], schema: StructType) extends Write {
+ override def toStreaming: StreamingWrite = {
+ new ContinuousMemoryStreamingWrite(batches, schema)
+ }
+}
+
+/**
+ * An RPC endpoint that receives rows and stores them to the ArrayBuffer in real-time.
+ */
+class MemoryRealTimeRpcEndpoint(
+ override val rpcEnv: RpcEnv,
+ schema: StructType,
+ batches: ArrayBuffer[Row]
+) extends ThreadSafeRpcEndpoint {
+ private val encoder = ExpressionEncoder(schema).resolveAndBind().createDeserializer()
+
+ override def receive: PartialFunction[Any, Unit] = {
+ case rows: Array[InternalRow] =>
+ // synchronized block is optional here since ThreadSafeRpcEndpoint already, just to be safe
+ batches.synchronized {
+ rows.foreach { row =>
+ batches += encoder(row)
+ }
+ }
+ }
+}
+
+class ContinuousMemoryStreamingWrite(val batches: ArrayBuffer[Row], schema: StructType)
+ extends StreamingWrite {
+
+ private val memoryEndpoint =
+ new MemoryRealTimeRpcEndpoint(
+ SparkEnv.get.rpcEnv,
+ schema,
+ batches
+ )
+ @volatile private var endpointRef: RpcEndpointRef = _
+
+ override def createStreamingWriterFactory(info: PhysicalWriteInfo): StreamingDataWriterFactory = {
+ val endpointName = s"MemoryRealTimeRpcEndpoint-${java.util.UUID.randomUUID()}"
+ endpointRef = memoryEndpoint.rpcEnv.setupEndpoint(endpointName, memoryEndpoint)
+ RealTimeRowWriterFactory(endpointName, endpointRef.address)
+ }
+
+ override def useCommitCoordinator(): Boolean = false
+
+ override def commit(epochId: Long, messages: Array[WriterCommitMessage]): Unit = {
+ // We don't need to commit anything in this case, as the rows have already been printed
+ if (endpointRef != null) {
+ memoryEndpoint.rpcEnv.stop(endpointRef)
+ }
Review Comment:
If this commit is called for each batch, does it mean that the endpoint stops to work after that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421372987
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemory.scala:
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import java.util
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.{SparkEnv, SparkUnsupportedOperationException}
+import org.apache.spark.rpc.{RpcEndpointRef, RpcEnv, ThreadSafeRpcEndpoint}
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
+import org.apache.spark.sql.connector.catalog.{SupportsWrite, TableCapability}
+import org.apache.spark.sql.connector.write.{
+ LogicalWriteInfo,
+ PhysicalWriteInfo,
+ Write,
+ WriteBuilder,
+ WriterCommitMessage
+}
+import org.apache.spark.sql.connector.write.streaming.{StreamingDataWriterFactory, StreamingWrite}
+import org.apache.spark.sql.internal.connector.SupportsStreamingUpdateAsAppend
+import org.apache.spark.sql.types.StructType
+
+/**
+ * A sink that stores the results in memory. This [[org.apache.spark.sql.execution.streaming.Sink]]
+ * is primarily intended for use in unit tests and does not provide durability.
+ * This is mostly copied from MemorySink, except that the data needs to be availalbe not in
+ * commit() but after each write.
+ */
+class ContinuousMemorySink
+ extends MemorySink
+ with SupportsWrite {
+
+ private val batches = new ArrayBuffer[Row]()
+ override def name(): String = "ContinuousMemorySink"
+
+ override def schema(): StructType = StructType(Nil)
+
+ override def capabilities(): util.Set[TableCapability] = {
+ util.EnumSet.of(TableCapability.STREAMING_WRITE)
+ }
+
+ override def newWriteBuilder(info: LogicalWriteInfo): WriteBuilder = {
+ new WriteBuilder with SupportsStreamingUpdateAsAppend {
+ private val inputSchema: StructType = info.schema()
+
+ override def build(): Write = {
+ new ContinuousMemoryWrite(batches, inputSchema)
+ }
+ }
+ }
+
+ /** Returns all rows that are stored in this [[Sink]]. */
+ override def allData: Seq[Row] = {
+ val batches = getBatches()
+ batches.synchronized {
+ batches.toSeq
+ }
+ }
+
+ override def latestBatchId: Option[Long] = {
+ None
+ }
+
+ override def latestBatchData: Seq[Row] = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "latestBatchData")
+ )
+ }
+
+ override def dataSinceBatch(sinceBatchId: Long): Seq[Row] = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "dataSinceBatch")
+ )
+ }
+
+ override def toDebugString: String = {
+ s"${allData}"
+ }
+
+ override def write(batchId: Long, needTruncate: Boolean, newRows: Array[Row]): Unit = {
+ throw new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_OPERATION_FOR_CONTINUOUS_MEMORY_SINK",
+ messageParameters = Map("operation" -> "write")
+ )
+ }
+
+ override def clear(): Unit = synchronized {
+ batches.clear()
+ }
+
+ private def getBatches(): ArrayBuffer[Row] = {
+ batches
+ }
+
+ override def toString(): String = "ContinuousMemorySink"
+}
+
+class ContinuousMemoryWrite(batches: ArrayBuffer[Row], schema: StructType) extends Write {
+ override def toStreaming: StreamingWrite = {
+ new ContinuousMemoryStreamingWrite(batches, schema)
+ }
+}
+
+/**
+ * An RPC endpoint that receives rows and stores them to the ArrayBuffer in real-time.
+ */
+class MemoryRealTimeRpcEndpoint(
+ override val rpcEnv: RpcEnv,
+ schema: StructType,
+ batches: ArrayBuffer[Row]
+) extends ThreadSafeRpcEndpoint {
+ private val encoder = ExpressionEncoder(schema).resolveAndBind().createDeserializer()
+
+ override def receive: PartialFunction[Any, Unit] = {
+ case rows: Array[InternalRow] =>
+ // synchronized block is optional here since ThreadSafeRpcEndpoint already, just to be safe
+ batches.synchronized {
+ rows.foreach { row =>
+ batches += encoder(row)
+ }
+ }
+ }
+}
+
+class ContinuousMemoryStreamingWrite(val batches: ArrayBuffer[Row], schema: StructType)
+ extends StreamingWrite {
+
+ private val memoryEndpoint =
+ new MemoryRealTimeRpcEndpoint(
+ SparkEnv.get.rpcEnv,
+ schema,
+ batches
+ )
+ @volatile private var endpointRef: RpcEndpointRef = _
+
+ override def createStreamingWriterFactory(info: PhysicalWriteInfo): StreamingDataWriterFactory = {
+ val endpointName = s"MemoryRealTimeRpcEndpoint-${java.util.UUID.randomUUID()}"
+ endpointRef = memoryEndpoint.rpcEnv.setupEndpoint(endpointName, memoryEndpoint)
+ RealTimeRowWriterFactory(endpointName, endpointRef.address)
+ }
+
+ override def useCommitCoordinator(): Boolean = false
+
+ override def commit(epochId: Long, messages: Array[WriterCommitMessage]): Unit = {
+ // We don't need to commit anything in this case, as the rows have already been printed
+ if (endpointRef != null) {
+ memoryEndpoint.rpcEnv.stop(endpointRef)
+ }
Review Comment:
Oh okay, I see. For each batch, there will be a new MemoryRealTimeRpcEndpoint created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "jerrypeng (via GitHub)" <gi...@apache.org>.
jerrypeng commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421534240
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RealTimeRowWriterFactory.scala:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import org.apache.spark.SparkEnv
+import org.apache.spark.rpc.RpcAddress
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.connector.write.{DataWriter, WriterCommitMessage}
+import org.apache.spark.sql.connector.write.streaming.StreamingDataWriterFactory
+import org.apache.spark.util.RpcUtils
+
+/**
+ * A [[StreamingDataWriterFactory]] that creates [[RealTimeRowWriter]], which sends rows to
+ * the driver in real-time through RPC.
+ *
+ * Note that, because it sends all rows to the driver, this factory will generally be unsuitable
+ * for production-quality sinks. It's intended for use in tests.
+ *
+ */
+case class RealTimeRowWriterFactory(
Review Comment:
Though I can rename it if you fee strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #52550:
URL: https://github.com/apache/spark/pull/52550#issuecomment-3395345786
Merged to master. Thanks @jerrypeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #52550: [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing
URL: https://github.com/apache/spark/pull/52550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "jerrypeng (via GitHub)" <gi...@apache.org>.
jerrypeng commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421532758
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RealTimeRowWriterFactory.scala:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import org.apache.spark.SparkEnv
+import org.apache.spark.rpc.RpcAddress
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.connector.write.{DataWriter, WriterCommitMessage}
+import org.apache.spark.sql.connector.write.streaming.StreamingDataWriterFactory
+import org.apache.spark.util.RpcUtils
+
+/**
+ * A [[StreamingDataWriterFactory]] that creates [[RealTimeRowWriter]], which sends rows to
+ * the driver in real-time through RPC.
+ *
+ * Note that, because it sends all rows to the driver, this factory will generally be unsuitable
+ * for production-quality sinks. It's intended for use in tests.
+ *
+ */
+case class RealTimeRowWriterFactory(
Review Comment:
Ah good question. The reason is because this code is going to be shared with the future RTM version of ConsoleStreamingWrite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53847] Add ContinuousMemorySink for Real-time Mode testing [spark]
Posted by "jerrypeng (via GitHub)" <gi...@apache.org>.
jerrypeng commented on code in PR #52550:
URL: https://github.com/apache/spark/pull/52550#discussion_r2421553204
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ContinuousMemory.scala:
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.sources
+
+import java.util
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.{SparkEnv, SparkUnsupportedOperationException}
+import org.apache.spark.rpc.{RpcEndpointRef, RpcEnv, ThreadSafeRpcEndpoint}
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
+import org.apache.spark.sql.connector.catalog.{SupportsWrite, TableCapability}
+import org.apache.spark.sql.connector.write.{
+ LogicalWriteInfo,
+ PhysicalWriteInfo,
+ Write,
+ WriteBuilder,
+ WriterCommitMessage
+}
+import org.apache.spark.sql.connector.write.streaming.{StreamingDataWriterFactory, StreamingWrite}
+import org.apache.spark.sql.internal.connector.SupportsStreamingUpdateAsAppend
+import org.apache.spark.sql.types.StructType
+
+/**
+ * A sink that stores the results in memory. This [[org.apache.spark.sql.execution.streaming.Sink]]
+ * is primarily intended for use in unit tests and does not provide durability.
+ * This is mostly copied from MemorySink, except that the data needs to be availalbe not in
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org