Re: [PR] CASSANDRA-19769: CEP-15: (Accord) sequence EpochReady.coordinating to allow syncComplete to be learned from newer epochs [cassandra]

["dcapwell (via GitHub)" <gi...@apache.org>]

dcapwell commented on code in PR #3416:
URL: https://github.com/apache/cassandra/pull/3416#discussion_r1777748507


##########
src/java/org/apache/cassandra/index/sai/utils/IndexTermType.java:
##########
@@ -745,7 +745,7 @@ private AbstractType<?> collectionCellValueType(AbstractType<?> type, IndexTarge
                         return CompositeType.getInstance(collection.nameComparator(), collection.valueComparator());
                 }
             default:
-                throw new IllegalArgumentException("Unsupported collection type: " + collection.kind);
+                throw new IllegalArgumentException("Unsupported collection type: " + collection.kind + "; index type: " + indexType.name());

Review Comment:
   unrelated to the patch, more a product of the fuzz testing...
   
   `RandomSchemaV2Test` now does far more randomness than before, includes accord, *and* tests indexes...
   
   This test is failing due to accord blocking indexes (which is a bug)... Celeb and Ariel are looking into this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org