[GitHub] [iceberg] rdblue commented on pull request #2622: Docs: add catalog and metadata files to metadata structure diagram

[GitBox <gi...@apache.org>]

rdblue commented on pull request #2622:
URL: https://github.com/apache/iceberg/pull/2622#issuecomment-846631871


   Thanks, @jasonhughes248! This looks like an improvement. I can share the original drawing with you if you want to edit that instead. There are also a couple of things we may want to change.
   
   First, I just gave a talk with what I think might be a better series of diagrams than the one here. I'd be interested in getting your feedback on that and whether we should replace the doc based on the new ones instead.
   [Iceberg Row-level Updates.pdf](https://github.com/apache/iceberg/files/6528986/Iceberg.Row-level.Updates.pdf)
   
   Second, assuming that we go with the older drawing, I think we also need to show that both snapshots, `s1` and `s2` exist in the same metadata file. One of the biggest misconceptions is that each metadata file points to a single snapshot, but they actually contain a list of all valid snapshots. Aging off snapshots removes older ones from that list and updates the history, then writes a new metadata file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org