You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@juneau.apache.org by gg...@apache.org on 2023/10/28 12:12:00 UTC
(juneau) branch master updated: Don't update instance variables to their default values
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new 3f188ac1d Don't update instance variables to their default values
3f188ac1d is described below
commit 3f188ac1da6ad797d2cc63922eb8b827b7f2b066
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Oct 28 08:11:49 2023 -0400
Don't update instance variables to their default values
---
.../main/java/org/apache/juneau/jena/RdfBeanPropertyMeta.java | 2 +-
.../src/main/java/org/apache/juneau/internal/ArrayBuilder.java | 2 +-
.../java/org/apache/juneau/internal/CharSequenceReader.java | 2 +-
.../src/main/java/org/apache/juneau/internal/MapBuilder.java | 2 +-
.../main/java/org/apache/juneau/objecttools/ObjectRest.java | 2 +-
.../src/main/java/org/apache/juneau/parser/ParserReader.java | 4 ++--
.../src/main/java/org/apache/juneau/utils/WeightedAverage.java | 2 +-
.../main/java/org/apache/juneau/xml/XmlBeanPropertyMeta.java | 2 +-
.../org/apache/juneau/examples/rest/RootResourcesTest.java | 2 +-
.../src/main/java/org/apache/juneau/http/BasicStatusLine.java | 2 +-
.../main/java/org/apache/juneau/rest/mock/MockHttpSession.java | 2 +-
.../java/org/apache/juneau/rest/mock/MockServletResponse.java | 2 +-
.../java/org/apache/juneau/rest/httppart/RequestContent.java | 2 +-
.../src/test/java/org/apache/juneau/DynaBeanComboTest.java | 4 ++--
.../apache/juneau/a/rttests/RoundTripBeanInheritanceTest.java | 10 +++++-----
.../test/java/org/apache/juneau/a/rttests/RoundTripTest.java | 2 +-
.../src/test/java/org/apache/juneau/html/Common_Test.java | 4 ++--
.../src/test/java/org/apache/juneau/json/CommonTest.java | 4 ++--
.../java/org/apache/juneau/json/JsonParserEdgeCasesTest.java | 2 +-
19 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/juneau-core/juneau-marshall-rdf/src/main/java/org/apache/juneau/jena/RdfBeanPropertyMeta.java b/juneau-core/juneau-marshall-rdf/src/main/java/org/apache/juneau/jena/RdfBeanPropertyMeta.java
index 8fd671003..30ddb8b19 100644
--- a/juneau-core/juneau-marshall-rdf/src/main/java/org/apache/juneau/jena/RdfBeanPropertyMeta.java
+++ b/juneau-core/juneau-marshall-rdf/src/main/java/org/apache/juneau/jena/RdfBeanPropertyMeta.java
@@ -35,7 +35,7 @@ public class RdfBeanPropertyMeta extends ExtendedBeanPropertyMeta {
private RdfCollectionFormat collectionFormat = RdfCollectionFormat.DEFAULT;
- private Namespace namespace = null;
+ private Namespace namespace;
private boolean isBeanUri;
/**
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/ArrayBuilder.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/ArrayBuilder.java
index 9d0949ab6..718595b4c 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/ArrayBuilder.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/ArrayBuilder.java
@@ -54,7 +54,7 @@ public final class ArrayBuilder<E> {
private Predicate<E> filter;
private final Class<E> elementType;
private int size = -1;
- private int i = 0;
+ private int i;
private List<E> list;
/**
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/CharSequenceReader.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/CharSequenceReader.java
index 4eaa1ebfb..90e048c1e 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/CharSequenceReader.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/CharSequenceReader.java
@@ -27,7 +27,7 @@ public final class CharSequenceReader extends BufferedReader {
private StringBuffer sb;
private StringBuilder sb2;
private int length;
- private int next = 0;
+ private int next;
/**
* Constructor.
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/MapBuilder.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/MapBuilder.java
index e6a84b94f..d6303fc02 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/MapBuilder.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/MapBuilder.java
@@ -37,7 +37,7 @@ public final class MapBuilder<K,V> {
private Map<K,V> map;
private boolean unmodifiable = false, sparse = false;
- private Comparator<K> comparator = null;
+ private Comparator<K> comparator;
private Class<K> keyType;
private Class<V> valueType;
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/objecttools/ObjectRest.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/objecttools/ObjectRest.java
index d7582b1dc..4b8d65e9f 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/objecttools/ObjectRest.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/objecttools/ObjectRest.java
@@ -166,7 +166,7 @@ public final class ObjectRest {
final BeanSession session;
/** If true, the root cannot be overwritten */
- private boolean rootLocked = false;
+ private boolean rootLocked;
/** The root of the model. */
private JsonNode root;
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
index 01b2f8725..9a07c3f6c 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
@@ -43,9 +43,9 @@ public class ParserReader extends Reader implements Positionable {
private char[] buff; // Internal character buffer
private int line = 1; // Current line number
private int column; // Current column number
- private int iCurrent = 0; // Current pointer into character buffer
+ private int iCurrent; // Current pointer into character buffer
private int iMark = -1; // Mark position in buffer
- private int iEnd = 0; // The last good character position in the buffer
+ private int iEnd; // The last good character position in the buffer
private boolean endReached, holesExist;
private final boolean unbuffered;
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/utils/WeightedAverage.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/utils/WeightedAverage.java
index 35fc8d0f8..b25f16497 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/utils/WeightedAverage.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/utils/WeightedAverage.java
@@ -20,7 +20,7 @@ package org.apache.juneau.utils;
*/
public class WeightedAverage {
private Double value = 0d;
- private int weight = 0;
+ private int weight;
/**
* Add a number with a weight to this average.
diff --git a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlBeanPropertyMeta.java b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlBeanPropertyMeta.java
index 6d1901211..edf623947 100644
--- a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlBeanPropertyMeta.java
+++ b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/xml/XmlBeanPropertyMeta.java
@@ -31,7 +31,7 @@ public class XmlBeanPropertyMeta extends ExtendedBeanPropertyMeta {
*/
public static final XmlBeanPropertyMeta DEFAULT = new XmlBeanPropertyMeta();
- private Namespace namespace = null;
+ private Namespace namespace;
private XmlFormat xmlFormat = XmlFormat.DEFAULT;
private String childName;
private final XmlMetaProvider xmlMetaProvider;
diff --git a/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java b/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
index 157acbdee..af159dc14 100644
--- a/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
+++ b/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
@@ -26,7 +26,7 @@ import org.junit.*;
@FixMethodOrder(NAME_ASCENDING)
public class RootResourcesTest extends RestTestcase {
- private static boolean debug = false;
+ private static boolean debug;
private RestClient jsonClient = SamplesMicroservice.DEFAULT_CLIENT;
diff --git a/juneau-rest/juneau-rest-common/src/main/java/org/apache/juneau/http/BasicStatusLine.java b/juneau-rest/juneau-rest-common/src/main/java/org/apache/juneau/http/BasicStatusLine.java
index aa530f204..e471edd5f 100644
--- a/juneau-rest/juneau-rest-common/src/main/java/org/apache/juneau/http/BasicStatusLine.java
+++ b/juneau-rest/juneau-rest-common/src/main/java/org/apache/juneau/http/BasicStatusLine.java
@@ -63,7 +63,7 @@ public class BasicStatusLine implements StatusLine {
private ProtocolVersion DEFAULT_PROTOCOL_VERSION = new ProtocolVersion("HTTP", 1, 1);
private ProtocolVersion protocolVersion = DEFAULT_PROTOCOL_VERSION;
- private int statusCode = 0;
+ private int statusCode;
private String reasonPhrase;
private ReasonPhraseCatalog reasonPhraseCatalog;
private Locale locale = Locale.getDefault();
diff --git a/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockHttpSession.java b/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockHttpSession.java
index 7691d2772..44d2eac38 100644
--- a/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockHttpSession.java
+++ b/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockHttpSession.java
@@ -38,7 +38,7 @@ public class MockHttpSession implements HttpSession {
private int maxInactiveInterval;
private String id;
private ServletContext servletContext;
- private boolean isNew = false;
+ private boolean isNew;
/**
* Creates a new HTTP session.
diff --git a/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockServletResponse.java b/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockServletResponse.java
index e7f57a116..6c656b6aa 100644
--- a/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockServletResponse.java
+++ b/juneau-rest/juneau-rest-mock/src/main/java/org/apache/juneau/rest/mock/MockServletResponse.java
@@ -34,7 +34,7 @@ public class MockServletResponse implements HttpServletResponse {
private String characterEncoding = "UTF-8";
private ByteArrayOutputStream baos = new ByteArrayOutputStream();
- private int bufferSize = 0;
+ private int bufferSize;
private Locale locale;
private int sc;
private String msg;
diff --git a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/httppart/RequestContent.java b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/httppart/RequestContent.java
index 3b6a6e552..a22f0621e 100644
--- a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/httppart/RequestContent.java
+++ b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/httppart/RequestContent.java
@@ -98,7 +98,7 @@ public class RequestContent {
private Encoder encoder;
private ParserSet parsers;
private long maxInput;
- private int contentLength = 0;
+ private int contentLength;
private MediaType mediaType;
private Parser parser;
private HttpPartSchema schema;
diff --git a/juneau-utest/src/test/java/org/apache/juneau/DynaBeanComboTest.java b/juneau-utest/src/test/java/org/apache/juneau/DynaBeanComboTest.java
index 34a87db76..a81e9f125 100644
--- a/juneau-utest/src/test/java/org/apache/juneau/DynaBeanComboTest.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/DynaBeanComboTest.java
@@ -248,7 +248,7 @@ public class DynaBeanComboTest extends ComboRoundTripTest {
private int f1, f3;
private Map<String,Object> f2 = new LinkedHashMap<>();
- private boolean setterCalled = false;
+ private boolean setterCalled;
public int getF1() {
return f1;
@@ -287,7 +287,7 @@ public class DynaBeanComboTest extends ComboRoundTripTest {
private int f1, f3;
private Map<String,Object> f2 = new LinkedHashMap<>();
- private boolean setterCalled = false;
+ private boolean setterCalled;
public int getF1() {
return f1;
diff --git a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripBeanInheritanceTest.java b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripBeanInheritanceTest.java
index 252272428..739a47d78 100755
--- a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripBeanInheritanceTest.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripBeanInheritanceTest.java
@@ -52,9 +52,9 @@ public class RoundTripBeanInheritanceTest extends RoundTripTest {
public static abstract class A1 {
- protected String x = null;
- protected String y = null;
- protected String z = null;
+ protected String x;
+ protected String y;
+ protected String z;
public A1() {
this.x = null;
@@ -172,9 +172,9 @@ public class RoundTripBeanInheritanceTest extends RoundTripTest {
}
public static class B2 {
- private String f1 = null;
+ private String f1;
private int f2 = -1;
- private boolean f3 = false;
+ private boolean f3;
public String getF1() {
return this.f1;
diff --git a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest.java b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest.java
index 01649db96..ee64499e7 100755
--- a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripTest.java
@@ -155,7 +155,7 @@ public abstract class RoundTripTest {
protected boolean returnOriginalObject;
private boolean validateXml;
protected String label;
- public boolean debug = false;
+ public boolean debug;
public RoundTripTest(String label, Serializer.Builder s, Parser.Builder p, int flags) throws Exception {
this.label = label;
diff --git a/juneau-utest/src/test/java/org/apache/juneau/html/Common_Test.java b/juneau-utest/src/test/java/org/apache/juneau/html/Common_Test.java
index b80a4c2aa..0a1bfa2e0 100755
--- a/juneau-utest/src/test/java/org/apache/juneau/html/Common_Test.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/html/Common_Test.java
@@ -409,9 +409,9 @@ public class Common_Test {
}
public static class J {
- private String f1 = null;
+ private String f1;
private int f2 = -1;
- private boolean f3 = false;
+ private boolean f3;
public String getF1() {
return this.f1;
diff --git a/juneau-utest/src/test/java/org/apache/juneau/json/CommonTest.java b/juneau-utest/src/test/java/org/apache/juneau/json/CommonTest.java
index 1db645b2d..3300957a1 100755
--- a/juneau-utest/src/test/java/org/apache/juneau/json/CommonTest.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/json/CommonTest.java
@@ -290,9 +290,9 @@ public class CommonTest {
}
public static class J {
- private String f1 = null;
+ private String f1;
private int f2 = -1;
- private boolean f3 = false;
+ private boolean f3;
public String getF1() {
return this.f1;
diff --git a/juneau-utest/src/test/java/org/apache/juneau/json/JsonParserEdgeCasesTest.java b/juneau-utest/src/test/java/org/apache/juneau/json/JsonParserEdgeCasesTest.java
index 4c31f2c18..4901e48be 100644
--- a/juneau-utest/src/test/java/org/apache/juneau/json/JsonParserEdgeCasesTest.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/json/JsonParserEdgeCasesTest.java
@@ -357,7 +357,7 @@ public class JsonParserEdgeCasesTest {
private final String name, errorText, jsonReadable;
private final Object json;
private final char expected;
- public boolean debug = false;
+ public boolean debug;
public JsonParserEdgeCasesTest(Integer testNum, String name, String json, String errorText) throws Exception {
this.name = name;