[GitHub] [airflow] ashb commented on pull request #25532: Move session.rollback closer to the exception

[GitBox <gi...@apache.org>]

ashb commented on PR #25532:
URL: https://github.com/apache/airflow/pull/25532#issuecomment-1205267400

   > ^^ And it seems sql alchemy tries to retrieve the object and load it and it tries to execute SQL command but irt finds out that rollback is Pending and should be executed before..
   
   ```
     File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/state.py", line 710, in _load_expired
   ```
   
   This attribute has been marked as expired, so SQLA is trying to reload the value. SQLA doesn't do this by itself, so _somewhere_ we are expiring the object (but leaving it attached to the session. If it was detached via `expunge` it would behave differently.)
   
   Do we do make any calls to `expire`/`expire_all` after this object was loaded but before it was accessed in this block?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org