You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by heary-cao <gi...@git.apache.org> on 2017/09/05 08:39:43 UTC

[GitHub] spark pull request #19131: [MINOR][SQL]remove unuse import class

GitHub user heary-cao opened a pull request:

    https://github.com/apache/spark/pull/19131

    [MINOR][SQL]remove unuse import class

    ## What changes were proposed in this pull request?
    
    this PR describe remove the import class that are unused.
    
    ## How was this patch tested?
    
    N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heary-cao/spark unuse_import

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19131
    
----
commit 01f8f8c0086721514b3abc36d7737f89a69caa09
Author: caoxuewen <ca...@zte.com.cn>
Date:   2017-09-05T08:28:59Z

    remove unuse import class

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    On the one hand, we don't normally just make a change to remove unused imports. But it's a good idea once in a while to clean up. Would you actually try to find all of them? at least, in several whole modules rather than part of one.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81563/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81553/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    What about other components, here you only fixed sql and core module.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    ok, i will do it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19131: [MINOR][SQL]remove unuse import class

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19131


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #81541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81541/testReport)** for PR 19131 at commit [`648ed11`](https://github.com/apache/spark/commit/648ed1165e3913ac919e0dc02608887c9ee6d7c1).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    I didn't think scalastyle could do that? didn't see a rule at http://www.scalastyle.org/rules-dev.html


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #3913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3913/testReport)** for PR 19131 at commit [`e7ce4e5`](https://github.com/apache/spark/commit/e7ce4e5c6594359df96ef7a52ae63344f5b99a22).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    @srowen, @jerryshao several other components, Include spark streaming, launcher,graphx,core,mllib,mllib-local, except for their tests. 
    thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Jenkins, test this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #81563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81563/testReport)** for PR 19131 at commit [`ee0d848`](https://github.com/apache/spark/commit/ee0d84866cad5fe829f630efa2137f51834f3a7c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    I'm going to merge it as a cleanup but yeah let's not do these often.
    I would favor adding a style check for this if one can be found, but don't see it in scalastyle.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #3913 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3913/testReport)** for PR 19131 at commit [`e7ce4e5`](https://github.com/apache/spark/commit/e7ce4e5c6594359df96ef7a52ae63344f5b99a22).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    wait, I'm still looking for it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81541/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #81563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81563/testReport)** for PR 19131 at commit [`ee0d848`](https://github.com/apache/spark/commit/ee0d84866cad5fe829f630efa2137f51834f3a7c).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    I'm neutral. Once in a while a cleanup seems helpful, not all the time. I am a little more receptive to people without much contribution history. But yeah I do not want to review things like this regularly. We have a lot of really minor PRs coming through


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Jenkins, test this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #81553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81553/testReport)** for PR 19131 at commit [`bdc1bcf`](https://github.com/apache/spark/commit/bdc1bcf1ac93df3dea6eef03de6162c8a2caccbd).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by ash211 <gi...@git.apache.org>.
Github user ash211 commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    A check for unused imports should be added to scalastyle to prevent these from creeping back in.  If this PR was accompanied with that check (failing before, now passing) I think the merge conflicts are worth it to permanently fix the problem.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #81553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81553/testReport)** for PR 19131 at commit [`bdc1bcf`](https://github.com/apache/spark/commit/bdc1bcf1ac93df3dea6eef03de6162c8a2caccbd).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    **[Test build #81541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81541/testReport)** for PR 19131 at commit [`648ed11`](https://github.com/apache/spark/commit/648ed1165e3913ac919e0dc02608887c9ee6d7c1).
     * This patch **fails to build**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/19131
  
    Personally I'm not fond of such fix, this will break lots of existing PRs and force them to rebase again. Usually this could be addressed when fixing other issues. IMHO I don't encourage such PRs.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org