You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/14 08:35:26 UTC
[GitHub] [iotdb] liuminghui233 opened a new pull request #4572: [To rel/0.12] [IOTDB-2101] Reduce the memory footprint of QueryDataSource
liuminghui233 opened a new pull request #4572:
URL: https://github.com/apache/iotdb/pull/4572
Improved version based on #4541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4572: [To rel/0.12] [IOTDB-2101] Reduce the memory footprint of QueryDataSource
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #4572:
URL: https://github.com/apache/iotdb/pull/4572#discussion_r770444567
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -734,7 +734,7 @@ private void recoverTsFiles(List<TsFileResource> tsFiles, boolean isSeq) throws
}
workUnsequenceTsFileProcessors.put(timePartitionId, tsFileProcessor);
}
- tsFileResource.setProcessor(tsFileProcessor);
+ ((UnclosedTsFileResource) tsFileResource).setProcessor(tsFileProcessor);
Review comment:
You cannot directly cast it to `UnclosedTsFileResource`, it must be `TsFileResource` when it is created while recovering.
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1736,35 +1746,67 @@ public void closeQueryUnLock() {
closeQueryLock.readLock().unlock();
}
}
+
return tsfileResourcesForQuery;
}
- /**
- * @param tsFileResources includes sealed and unsealed tsfile resources
- * @return fill unsealed tsfile resources with memory data and ChunkMetadataList of data in disk
- */
- private Pair<List<TsFileResource>, TsFileResource> getFileResourceListForQuery(
- Collection<TsFileResource> tsFileResources, Filter timeFilter, boolean isSeq)
+ private List<TsFileResource> getFileResourceListForQuery(
Review comment:
Add java doc for the previous `getFileResourceListForQuery` function, indicating that is only used for last and fill query.
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1614,16 +1613,35 @@ public QueryDataSource query(
}
}
- public QueryDataSource getAllQueryDataSource(Filter timeFilter) throws QueryProcessException {
+ public QueryDataSource query(
Review comment:
Add java doc for the previous query() function, indicating that is only used for last and fill query.
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -2885,6 +2927,10 @@ public String getVirtualStorageGroupId() {
return virtualStorageGroupId;
}
+ public String getStorageGroupPath() {
Review comment:
add java doc, return virtual storage group name, like root.sg1/0
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1586,15 +1584,15 @@ public QueryDataSource query(
getFileResourceListForQuery(
tsFileManagement.getTsFileList(true),
upgradeSeqFileList,
- fullPath,
+ pathList,
context,
timeFilter,
true);
List<TsFileResource> unseqResources =
getFileResourceListForQuery(
tsFileManagement.getTsFileList(false),
- upgradeUnseqFileList,
- fullPath,
+ upgradeSeqFileList,
Review comment:
```suggestion
upgradeUnSeqFileList,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4572: [To rel/0.12] [IOTDB-2101] Reduce the memory footprint of QueryDataSource
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4572:
URL: https://github.com/apache/iotdb/pull/4572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] liuminghui233 commented on a change in pull request #4572: [To rel/0.12] [IOTDB-2101] Reduce the memory footprint of QueryDataSource
Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on a change in pull request #4572:
URL: https://github.com/apache/iotdb/pull/4572#discussion_r771329784
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -2885,6 +2927,10 @@ public String getVirtualStorageGroupId() {
return virtualStorageGroupId;
}
+ public String getStorageGroupPath() {
Review comment:
fixed
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1586,15 +1584,15 @@ public QueryDataSource query(
getFileResourceListForQuery(
tsFileManagement.getTsFileList(true),
upgradeSeqFileList,
- fullPath,
+ pathList,
context,
timeFilter,
true);
List<TsFileResource> unseqResources =
getFileResourceListForQuery(
tsFileManagement.getTsFileList(false),
- upgradeUnseqFileList,
- fullPath,
+ upgradeSeqFileList,
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org