[jira] [Commented] (GRIFFIN-123) [Measure] Code review of measure module, refactor and enhance the code style

["William Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GRIFFIN-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471304#comment-16471304 ] 

William Guo commented on GRIFFIN-123:
-------------------------------------

first of first, we need to improve measure test cases, refactor measure interface to make our code clean and easily to contribute. 

personally, I think we need to write down our test case by given-when-then traits, for other contributors to understand our logic, especially for scala scripting.

 

when our improve our test case, definitely, we can make our code readable by refactoring ... 

> [Measure] Code review of measure module, refactor and enhance the code style
> ----------------------------------------------------------------------------
>
>                 Key: GRIFFIN-123
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-123
>             Project: Griffin (Incubating)
>          Issue Type: Improvement
>            Reporter: Lionel Liu
>            Assignee: William Guo
>            Priority: Major
>   Original Estimate: 72h
>          Time Spent: 12h
>  Remaining Estimate: 60h
>
> Code review of measure module, refactor and enhance the code style



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)