You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/07/26 14:16:22 UTC

svn commit: r1613611 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/state/SetLineDashPattern.java

Author: tilman
Date: Sat Jul 26 12:16:22 2014
New Revision: 1613611

URL: http://svn.apache.org/r1613611
Log:
PDFBOX-2243: adjust negative dash phase start value to 0

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/state/SetLineDashPattern.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/state/SetLineDashPattern.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/state/SetLineDashPattern.java?rev=1613611&r1=1613610&r2=1613611&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/state/SetLineDashPattern.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/operator/state/SetLineDashPattern.java Sat Jul 26 12:16:22 2014
@@ -18,6 +18,9 @@ package org.apache.pdfbox.util.operator.
 
 import java.util.List;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import org.apache.pdfbox.cos.COSArray;
 import org.apache.pdfbox.cos.COSBase;
 import org.apache.pdfbox.cos.COSNumber;
@@ -32,12 +35,22 @@ import org.apache.pdfbox.util.operator.O
  */
 public class SetLineDashPattern extends OperatorProcessor
 {
+    /**
+     * log instance
+     */
+    private static final Log LOG = LogFactory.getLog(SetLineDashPattern.class);
+
     @Override
     public void process(Operator operator, List<COSBase> arguments)
     {
-        COSArray dashArray = (COSArray)arguments.get( 0 );
-        int dashPhase = ((COSNumber)arguments.get( 1 )).intValue();
-        PDLineDashPattern lineDash = new PDLineDashPattern( dashArray, dashPhase );
-        context.getGraphicsState().setLineDashPattern( lineDash );
+        COSArray dashArray = (COSArray) arguments.get(0);
+        int dashPhase = ((COSNumber) arguments.get(1)).intValue();
+        if (dashPhase < 0)
+        {
+            LOG.warn("dash phaseStart has negative value " + dashPhase + ", set to 0");
+            dashPhase = 0;
+        }
+        PDLineDashPattern lineDash = new PDLineDashPattern(dashArray, dashPhase);
+        context.getGraphicsState().setLineDashPattern(lineDash);
     }
 }