You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2017/01/03 22:06:41 UTC

[Impala-ASF-CR] DOCS-1757

ambreen.kazi@cloudera.com has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5594

Change subject: DOCS-1757
......................................................................

DOCS-1757

Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
---
M docs/topics/impala_authorization.xml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/5594/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: ambreen.kazi@cloudera.com

[Impala-ASF-CR] Change one instance of namenode to NameNode

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.

Ambreen Kazi has posted comments on this change.

Change subject: Change one instance of namenode to NameNode
......................................................................


Patch Set 2:

(3 comments)

Thanks Jim. I think that's it for this one.

http://gerrit.cloudera.org:8080/#/c/5594/1//COMMIT_MSG
Commit Message:

Line 7: Change one instance of namenode to NameNode
> Please add an IMPALA bug number, or omit if none. DOCS is an internal Cloud
Done


Line 8: 
> Please add a description following the pattern you see when running git log
Done


http://gerrit.cloudera.org:8080/#/c/5594/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

Line 952:             Availability (HA). This ensures that the URI will remain constant even if the NameNode changes.
> Does this error get made anywhere else in the docs?
This was just a practice code review so I'm not pushing a global search/replace just yet.


-- 
To view, visit http://gerrit.cloudera.org:8080/5594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Change one instance of namenode to NameNode

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.

John Russell has posted comments on this change.

Change subject: Change one instance of namenode to NameNode
......................................................................

Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5594/1//COMMIT_MSG
Commit Message:

Line 7: DOCS-1757
> Please add an IMPALA bug number, or omit if none. DOCS is an internal Cloud
Done

Line 8:
> Please add a description following the pattern you see when running git log
Noted for future CRs by Ambreen. This sort of minor editorial fix on the doc side has traditionally had a self-descriptive commit message without a separate description.

http://gerrit.cloudera.org:8080/#/c/5594/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

Line 952: Availability (HA). This ensures that the URI will remain constant even if the NameNode changes.
> Does this error get made anywhere else in the docs?
Lowercase 'namenode' occurs in some other contexts that are unlikely to cause confusion. This instance came to our attention because of the camelcase version being used right next to the lowercase version. For gerrit practice purposes, I asked Ambreen to put it in as a 1-liner change request.

--
To view, visit http://gerrit.cloudera.org:8080/5594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] Change one instance of namenode to NameNode

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged.

Change subject: Change one instance of namenode to NameNode
......................................................................


Change one instance of namenode to NameNode

Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
Reviewed-on: http://gerrit.cloudera.org:8080/5594
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_authorization.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>