You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/09/12 23:30:37 UTC

[kudu-CR] [compaction] style guide-related updates

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18974


Change subject: [compaction] style guide-related updates
......................................................................

[compaction] style guide-related updates

I was debugging one compaction issue and found that compaction-related
code in compaction-test.cc isn't robust enough.  This patch just updates
the code in compaction.{h,cc} and compaction-test.cc to conform with the
project's style guidelines.  A follow-up patch is to make the code
in compaction-test.cc more robust.

There are no functional changes in this patch.

Change-Id: I4ef1981dad33a6bc2d0911630fd73c95b91e45fe
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
3 files changed, 119 insertions(+), 114 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18974/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef1981dad33a6bc2d0911630fd73c95b91e45fe
Gerrit-Change-Number: 18974
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [compaction] style guide-related updates

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18974 )

Change subject: [compaction] style guide-related updates
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef1981dad33a6bc2d0911630fd73c95b91e45fe
Gerrit-Change-Number: 18974
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 12:21:34 +0000
Gerrit-HasComments: No

[kudu-CR] [compaction] style guide-related updates

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18974 )

Change subject: [compaction] style guide-related updates
......................................................................

[compaction] style guide-related updates

I was debugging one compaction issue and found that compaction-related
code in compaction-test.cc isn't robust enough.  This patch just updates
the code in compaction.{h,cc} and compaction-test.cc to conform with the
project's style guidelines.  A follow-up patch is to make the code
in compaction-test.cc more robust.

There are no functional changes in this patch.

Change-Id: I4ef1981dad33a6bc2d0911630fd73c95b91e45fe
Reviewed-on: http://gerrit.cloudera.org:8080/18974
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
3 files changed, 119 insertions(+), 114 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yifan Zhang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ef1981dad33a6bc2d0911630fd73c95b91e45fe
Gerrit-Change-Number: 18974
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>