[jira] [Commented] (FLINK-7362) CheckpointProperties are not correctly set when restoring savepoint with HA enabled

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116645#comment-16116645 ] 

ASF GitHub Bot commented on FLINK-7362:
---------------------------------------

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/4491

    [FLINK-7362] [checkpoints] Savepoint property is lost after de/serial…

    …ization of CheckpointProperties
    
    ## What is the purpose of the change
    
    This PR fixes lost information about the savepoint property when de/serializing `CheckpointProperty`. The problem was caused by serialization in connection with a singleton that was checked for referencial equality to derive the savepoint property.
    
    
    ## Brief change log
    
    This makes the savepoint property explicit as a boolean field in `CheckpointProperty`. 
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage. Nevertheless I added a small test.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink serializable-savepoint-property

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4491
    
----
commit 64eb3abb55f515252069371f7dd8f874b9c73c7e
Author: Stefan Richter <s....@data-artisans.com>
Date:   2017-08-07T14:22:32Z

    [FLINK-7362] [checkpoints] Savepoint property is lost after de/serialization of CheckpointProperties

----


> CheckpointProperties are not correctly set when restoring savepoint with HA enabled
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-7362
>                 URL: https://issues.apache.org/jira/browse/FLINK-7362
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.4.0, 1.3.2
>            Reporter: Aljoscha Krettek
>             Fix For: 1.4.0
>
>
> When restoring a savepoint on a HA setup (with ZooKeeper) the web frontend incorrectly says "Type: Checkpoint" in the information box about the latest restore event.
> The information that this uses is set here: https://github.com/apache/flink/blob/09caa9ffdc8168610c7d0260360c034ea87f904c/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L1101
> It seems that the {{CheckpointProperties}} of a restored savepoint somehow get lost, maybe because of the recover step that the {{ZookeeperCompletedCheckpointStore}} is going through.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)