You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/18 22:05:37 UTC
[GitHub] [spark] ueshin opened a new pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
ueshin opened a new pull request #34653:
URL: https://github.com/apache/spark/pull/34653
### What changes were proposed in this pull request?
Fixes `StatCounter` to use `mergeStats` instead of `merge` when merging with `self`.
### Why are the changes needed?
`StatCounter` should use `mergeStats` instead of `merge` when merging with `self`.
This is a long standing bug but usually this bug won't be hit unless users explicitly use `mergeStats` with `self`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973674002
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973602312
**[Test build #145411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145411/testReport)** for PR 34653 at commit [`8f56529`](https://github.com/apache/spark/commit/8f565299d35a0016807b21c32c6bd25a70733dca).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973650510
**[Test build #145426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145426/testReport)** for PR 34653 at commit [`f8dd803`](https://github.com/apache/spark/commit/f8dd8030b5c51fe75a609819cf4d608683532254).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973648142
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973674002
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973664417
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34653:
URL: https://github.com/apache/spark/pull/34653#discussion_r752729619
##########
File path: python/pyspark/tests/test_statcounter.py
##########
@@ -0,0 +1,98 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import unittest
+
+from pyspark.statcounter import StatCounter
+from pyspark.testing.utils import ReusedPySparkTestCase
+
+
+class StatCounterTests(ReusedPySparkTestCase):
+ def test_as_dict(self):
+ stats = self.sc.parallelize([1.0, 2.0, 3.0, 4.0]).stats()
+ self.assertDictEqual(
+ stats.asDict(),
+ {
+ "count": 4,
+ "max": 4.0,
+ "mean": 2.5,
+ "min": 1.0,
+ "stdev": 1.2909944487358056,
+ "sum": 10.0,
+ "variance": 1.6666666666666667,
+ },
+ )
+
+ def test_merge(self):
+ stats = StatCounter([1.0, 2.0, 3.0, 4.0])
+ stats.merge(5.0)
+ self.assertDictEqual(
+ stats.asDict(),
+ {
+ "count": 5,
+ "max": 5.0,
+ "mean": 3.0,
+ "min": 1.0,
+ "stdev": 1.5811388300841898,
+ "sum": 15.0,
+ "variance": 2.5,
+ },
+ )
+
+ def test_merge_stats(self):
+ stats1 = StatCounter([1.0, 2.0, 3.0, 4.0])
+ stats2 = StatCounter([1.0, 2.0, 3.0, 4.0])
+ merged = stats1.mergeStats(stats2)
+ self.assertDictEqual(
+ merged.asDict(),
+ {
+ "count": 8,
+ "max": 4.0,
+ "mean": 2.5,
+ "min": 1.0,
+ "stdev": 1.1952286093343936,
+ "sum": 20.0,
+ "variance": 1.4285714285714286,
Review comment:
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973446958
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49884/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34653:
URL: https://github.com/apache/spark/pull/34653#discussion_r752667556
##########
File path: python/pyspark/tests/test_statcounter.py
##########
@@ -0,0 +1,98 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import unittest
+
+from pyspark.statcounter import StatCounter
+from pyspark.testing.utils import ReusedPySparkTestCase
+
+
+class StatCounterTests(ReusedPySparkTestCase):
+ def test_as_dict(self):
+ stats = self.sc.parallelize([1.0, 2.0, 3.0, 4.0]).stats()
+ self.assertDictEqual(
+ stats.asDict(),
+ {
+ "count": 4,
+ "max": 4.0,
+ "mean": 2.5,
+ "min": 1.0,
+ "stdev": 1.2909944487358056,
+ "sum": 10.0,
+ "variance": 1.6666666666666667,
+ },
+ )
+
+ def test_merge(self):
+ stats = StatCounter([1.0, 2.0, 3.0, 4.0])
+ stats.merge(5.0)
+ self.assertDictEqual(
+ stats.asDict(),
+ {
+ "count": 5,
+ "max": 5.0,
+ "mean": 3.0,
+ "min": 1.0,
+ "stdev": 1.5811388300841898,
+ "sum": 15.0,
+ "variance": 2.5,
+ },
+ )
+
+ def test_merge_stats(self):
+ stats1 = StatCounter([1.0, 2.0, 3.0, 4.0])
+ stats2 = StatCounter([1.0, 2.0, 3.0, 4.0])
+ merged = stats1.mergeStats(stats2)
+ self.assertDictEqual(
+ merged.asDict(),
+ {
+ "count": 8,
+ "max": 4.0,
+ "mean": 2.5,
+ "min": 1.0,
+ "stdev": 1.1952286093343936,
+ "sum": 20.0,
+ "variance": 1.4285714285714286,
Review comment:
Just thinking out loud ‒ how robust is this? Wouldn't be better to compare individual values with `assertAlmostEqual`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973335150
**[Test build #145411 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145411/testReport)** for PR 34653 at commit [`8f56529`](https://github.com/apache/spark/commit/8f565299d35a0016807b21c32c6bd25a70733dca).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973604284
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145411/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973475716
**[Test build #145415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145415/testReport)** for PR 34653 at commit [`f8dd803`](https://github.com/apache/spark/commit/f8dd8030b5c51fe75a609819cf4d608683532254).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973728753
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145426/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973728753
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145426/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973675208
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49899/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973664516
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34653:
URL: https://github.com/apache/spark/pull/34653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973549164
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49884/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973582133
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49884/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973582133
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49884/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973576706
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973604284
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145411/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973648329
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973650510
**[Test build #145426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145426/testReport)** for PR 34653 at commit [`f8dd803`](https://github.com/apache/spark/commit/f8dd8030b5c51fe75a609819cf4d608683532254).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973475716
**[Test build #145415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145415/testReport)** for PR 34653 at commit [`f8dd803`](https://github.com/apache/spark/commit/f8dd8030b5c51fe75a609819cf4d608683532254).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973311783
cc @dchvn @zero323 @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973335150
**[Test build #145411 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145411/testReport)** for PR 34653 at commit [`8f56529`](https://github.com/apache/spark/commit/8f565299d35a0016807b21c32c6bd25a70733dca).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973648329
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973649720
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973675208
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49899/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973719217
**[Test build #145426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145426/testReport)** for PR 34653 at commit [`f8dd803`](https://github.com/apache/spark/commit/f8dd8030b5c51fe75a609819cf4d608683532254).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34653: [SPARK-37374][PYTHON] Fix StatCounter to use mergeStats when merging with self
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34653:
URL: https://github.com/apache/spark/pull/34653#issuecomment-973663295
**[Test build #145415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145415/testReport)** for PR 34653 at commit [`f8dd803`](https://github.com/apache/spark/commit/f8dd8030b5c51fe75a609819cf4d608683532254).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org