You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/01 18:09:00 UTC

[jira] [Work logged] (BEAM-6753) Create proto representation for schemas

     [ https://issues.apache.org/jira/browse/BEAM-6753?focusedWorklogId=221391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221391 ]

ASF GitHub Bot logged work on BEAM-6753:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/19 18:08
            Start Date: 01/Apr/19 18:08
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on pull request #7952: [BEAM-6753] Set the stage to make schema coder update compatible
URL: https://github.com/apache/beam/pull/7952#discussion_r270987733
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java
 ##########
 @@ -285,15 +289,24 @@ public InstrumentedType prepare(InstrumentedType instrumentedType) {
     // per-field Coders.
     static Row decodeDelegate(Schema schema, Coder[] coders, InputStream inputStream)
         throws IOException {
+      int fieldCount = VAR_INT_CODER.decode(inputStream);
 
 Review comment:
   Unfortunately no. BitSet.size() returns the total space used, which rounds up to the next word size.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 221391)
    Time Spent: 50m  (was: 40m)

> Create proto representation for schemas
> ---------------------------------------
>
>                 Key: BEAM-6753
>                 URL: https://issues.apache.org/jira/browse/BEAM-6753
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-model
>            Reporter: Reuven Lax
>            Assignee: Reuven Lax
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)