You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/25 11:01:37 UTC

[GitHub] [commons-lang] HubertWo opened a new pull request #633: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream`

HubertWo opened a new pull request #633:
URL: https://github.com/apache/commons-lang/pull/633


   This PR is related to: https://github.com/apache/commons-lang/pull/400 
   
   I have pulled most recent changes from repository and used ```try-with-resources``` to correctly close resources. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-lang] coveralls commented on pull request #633: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream`

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #633:
URL: https://github.com/apache/commons-lang/pull/633#issuecomment-716129675


   
   [![Coverage Status](https://coveralls.io/builds/34439094/badge)](https://coveralls.io/builds/34439094)
   
   Coverage decreased (-0.01%) to 94.676% when pulling **069bf9263a1bcbbcce2b5c043ca82dd43e89ee18 on HubertWo:closeStreams** into **110b4c021e4901efab91499fedcdfb43c564ebdf on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-lang] garydgregory closed pull request #633: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream`

Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #633:
URL: https://github.com/apache/commons-lang/pull/633


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-lang] garydgregory commented on pull request #633: Close/flush the `OutputStream` before calling `toByteArray()` on underlying `ByteArrayOutputStream`

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #633:
URL: https://github.com/apache/commons-lang/pull/633#issuecomment-716160426


   -1 Implemented differently, see git master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org