You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Manoj Khangaonkar (JIRA)" <ji...@apache.org> on 2007/02/06 09:17:05 UTC

[jira] Created: (AXIS2-2116) java2WSDL should generate schema elements for public fields

java2WSDL should generate schema elements for public fields
-----------------------------------------------------------

                 Key: AXIS2-2116
                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
             Project: Axis 2.0 (Axis2)
          Issue Type: Improvement
          Components: wsdl
    Affects Versions: 1.1.1, 1.2, nightly
         Environment: ALL
            Reporter: Manoj Khangaonkar


When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.

If I have a class that has fields without get/set methods like

public class Book {

public String title ;
public String author ;

}

The complex type in types section of the WSDL is

<xs:complexType name="Book">
<xs:sequence />
</xs:complexType>

It should be

<xs:complexType name="Book">
<xs:sequence >
<xs:element name="title" nillable="true" type="xs:string" />
<xs:element name="author" nillable="true" type="xs:string" />
</xs;sequence>
</xs:complexType>

java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Resolved: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davanum Srinivas resolved AXIS2-2116.
-------------------------------------

    Resolution: Fixed

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, axis2patch1749and2116-v3.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470696 ] 

Manoj Khangaonkar commented on AXIS2-2116:
------------------------------------------

Deepal,

There is no reason to have the limitation that AXIS2 supports only java beans. Remember that java2WSDL is typically used
to generate WSDL for legacy java code. The legacy code may or may not be java bean. It seems unreasonable that java2WSDL cannot
handle class if there are no get/set methods.

I propose this as an enhancement. I know how to fix it and will provide the patch.

Currently java2WSDL uses codehaus library for introspecting the metthods/parameters in the input java class. When
introspecting the parameters, the code gets only the "properties" from the class. We really need to get the "properties" and
"fields".

"fields" in codehaus refers to public members of the class.

If you see any serious downside to doing this, let me know - other wise I can provide a patch.

Even if we decide not to support this , the code should print a warning and not spit out incorrect WSDL.

Dims,

The issue is that the generated WSDL is incorrect. This is straight - generation of WSDL from java - so unless I am missing
something obvious - there are no databinding issues here.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472003 ] 

Manoj Khangaonkar commented on AXIS2-2116:
------------------------------------------

Deepal / Dims,

What do think of the patch ?

I am also starting to look at AXIS2-1749. But a fix for AXIS2-1749 would need to on top of 
AXIS2- 2116 , if this patch is accepted - that is.

It would be double work to provide a patch for 1749 now on existing codebase and then com back and provide
an additional fix for the additional code that patch 2116 provides.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476304 ] 

Manoj Khangaonkar commented on AXIS2-2116:
------------------------------------------

Hi Deepal,

Did not notice your comments earlier.

I'll create a combined patch in the next couple of days. 

In case I miss the code freeze -- the patch for 1749 can go in on its own - it will fit in with the existing code.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476846 ] 

Deepal Jayasinghe commented on AXIS2-2116:
------------------------------------------

Hi Manoj;

I tried to apply your patch , but I got a number of conflicts . Can you please attach the pathc using current SVN code base.

Thanks
Deepal

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470717 ] 

Davanum Srinivas commented on AXIS2-2116:
-----------------------------------------

Manoj,

+1 for a patch :)

thanks,
dims

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470575 ] 

Davanum Srinivas commented on AXIS2-2116:
-----------------------------------------

Manoj,

Our JIBX databinding layer should be able to handle this. Please look at the documentation.

thanks,
dims

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478266 ] 

Manoj Khangaonkar commented on AXIS2-2116:
------------------------------------------

Hi Deepal,

Can you please commit this patch ?

I would like to provide a patch for AXIS2-2239 and it affects the same code. 

If I provide that patch on top of commited code - there is less chance of confflicts later on.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manoj Khangaonkar updated AXIS2-2116:
-------------------------------------

    Attachment: patch2116.txt

patch is attached.

If there is property and a public field with the same name, the property is used ( instead of the field).

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manoj Khangaonkar updated AXIS2-2116:
-------------------------------------

    Attachment: axis2patch1749and2116-v3.txt

Dims,

Attached a updated patch for the latest revision.

WOuld appreciate if we can commit before someone changes the code again.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, axis2patch1749and2116-v3.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474948 ] 

Deepal Jayasinghe commented on AXIS2-2116:
------------------------------------------

Hi Manoj,
I tried to apply your patch but I got couple of conflicts , so can you please create a new patch and attach.

Thanks
Deepal

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manoj Khangaonkar updated AXIS2-2116:
-------------------------------------

    Attachment: axis2-1749and2116.txt

Attached a patch that include both 1749 and 2116

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481910 ] 

Davanum Srinivas commented on AXIS2-2116:
-----------------------------------------

Fixed in svn revision 519539

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, axis2patch1749and2116-v3.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Resolved: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepal Jayasinghe resolved AXIS2-2116.
--------------------------------------

    Resolution: Won't Fix

Hi ;
We only support Java beans , so we can not generate wsdl for non Java bean objects.

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474949 ] 

Deepal Jayasinghe commented on AXIS2-2116:
------------------------------------------

Hi Manjo;
Pls create a one patch for bot 1749 and 2116

Thanks
Deepal

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476715 ] 

Manoj Khangaonkar commented on AXIS2-2116:
------------------------------------------

Hi Deepal,

To integrate 1749 with 2116, I ran into a small issue that required me to open a bug on Annogen - org.codehaus.jam.

The bug is Annogen-21 - getDeclaredFields method of JClass returns fields of base class as well - It should not. For 1749 - I need it
to return just the fields of the current class - not of all the base classes

I am writing a wrapper method to work around the issue - until there is a fix from Annogen.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Reopened: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davanum Srinivas reopened AXIS2-2116:
-------------------------------------


I've reopened the issue.

thanks,
dims

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manoj Khangaonkar updated AXIS2-2116:
-------------------------------------

    Attachment: axis2patch1749and2116-v2.txt

Hi Deepal,

Attached is a patch based on the latest source code in SVN.

The only conflicts I saw were calls to getSimpleName and getQualifiedName - these are wrapper methods on JAM that were added. 

There should be no conflicts now. If you still see a conflict, please show the code that has a conflict so I can understand what the conflict is

Mj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481448 ] 

Davanum Srinivas commented on AXIS2-2116:
-----------------------------------------

Manoj,

Could i trouble u to please submit a fresh patch against latest svn? getting errors applying the latest one.

-- dims

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-2116) java2WSDL should generate schema elements for public fields

Posted by "Manoj Khangaonkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481895 ] 

Manoj Khangaonkar commented on AXIS2-2116:
------------------------------------------

Hi,

I will provide a patch against latest svn - In any case I need to update the patch based on a comment from 1749.

How this patch was created on march 1. Since march 1 , there have been 2 checkins to the same file , but it changes different parts of the file.

So I am not seeing any conflict --- by conflict I am thinking - two people updating the same lines of code differently.

In any case I will merge with latest one more time.

Manoj

> java2WSDL should generate schema elements for public fields
> -----------------------------------------------------------
>
>                 Key: AXIS2-2116
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2116
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Improvement
>          Components: wsdl
>    Affects Versions: 1.2, 1.1.1, nightly
>         Environment: ALL
>            Reporter: Manoj Khangaonkar
>         Attachments: axis2-1749and2116.txt, axis2patch1749and2116-v2.txt, patch2116.txt
>
>
> When java2WSDL generates schema for method parameters, it generates elements only for "properties" - those that have get/set metthods.
> If I have a class that has fields without get/set methods like
> public class Book {
> public String title ;
> public String author ;
> }
> The complex type in types section of the WSDL is
> <xs:complexType name="Book">
> <xs:sequence />
> </xs:complexType>
> It should be
> <xs:complexType name="Book">
> <xs:sequence >
> <xs:element name="title" nillable="true" type="xs:string" />
> <xs:element name="author" nillable="true" type="xs:string" />
> </xs;sequence>
> </xs:complexType>
> java2wsdl is typically used to generate WSDL for legacy code and it is not reasonable to expect users to go add get/set methods to legacy code
> just because they need to generate WSDL

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org