You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2022/09/29 12:13:00 UTC
[GitHub] [ambari] smallyao opened a new pull request, #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
smallyao opened a new pull request, #3375:
URL: https://github.com/apache/ambari/pull/3375
## What changes were proposed in this pull request?
Fix the issue that MapReduce actions menu lack service check button
The reason seems caused by [AMBARI-24921](https://issues.apache.org/jira/browse/AMBARI-24921).
When access to MapReduce page, in the file app/views/main/service/item.js at line 162
`service.get('installedClients')// result is null `,
so the code
`var hasClient = App.StackService.find(serviceName).get('hasClient') ? service.get('installedClients') > 0 : true;
var serviceCheckSupported = App.get('services.supportsServiceCheck').contains(serviceName) && hasClient;
`
will make the variable serviceCheckSupported is false that lead to the Service Check buttion invisible
## How was this patch tested?
Tested in local vm cluster.
After applying this patch, this issue is fixed.
As shown in following picture
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] smallyao commented on pull request #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
Posted by GitBox <gi...@apache.org>.
smallyao commented on PR #3375:
URL: https://github.com/apache/ambari/pull/3375#issuecomment-1264403962
> Thanks @smallyao , Could you help delete the following two lines https://github.com/apache/ambari/blob/trunk/ambari-web/app/mappers/service_metrics_mapper.js#L137 https://github.com/apache/ambari/blob/trunk/ambari-web/app/models/service/mapreduce2.js#L22
@kevinw66 Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] virajjasani commented on pull request #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
Posted by GitBox <gi...@apache.org>.
virajjasani commented on PR #3375:
URL: https://github.com/apache/ambari/pull/3375#issuecomment-1264121684
> The reason seems caused by [AMBARI-24921](https://issues.apache.org/jira/browse/AMBARI-24921).
I see, since this is not committed on 2.6 releases, I don't see this problem but the fix looks reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 merged pull request #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #3375:
URL: https://github.com/apache/ambari/pull/3375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] smallyao commented on a diff in pull request #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
Posted by GitBox <gi...@apache.org>.
smallyao commented on code in PR #3375:
URL: https://github.com/apache/ambari/pull/3375#discussion_r984239326
##########
ambari-web/app/mappers/components_state_mapper.js:
##########
@@ -103,7 +103,8 @@ App.componentsStateMapper = App.QuickDataMapper.create({
ranger_tagsyncs_total: 'TOTAL_PATH'
},
'MAPREDUCE2_CLIENT': {
Review Comment:
@kevinw66 Thanks for your review.
It works fine after removing this code and I find the variable `mapReduce2Client` never be used in ambari web.
So it is safe to delete this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on a diff in pull request #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #3375:
URL: https://github.com/apache/ambari/pull/3375#discussion_r983698512
##########
ambari-web/app/mappers/components_state_mapper.js:
##########
@@ -103,7 +103,8 @@ App.componentsStateMapper = App.QuickDataMapper.create({
ranger_tagsyncs_total: 'TOTAL_PATH'
},
'MAPREDUCE2_CLIENT': {
Review Comment:
Will it be better if we remove the whole config of "MAPREDUCE2_CLIENT" and `map_reduce2_clients` here https://github.com/apache/ambari/blob/trunk/ambari-web/app/mappers/service_metrics_mapper.js#L137 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on pull request #3375: AMBARI-25744: MapReduce Actions Menu Lacks Service Check Button
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #3375:
URL: https://github.com/apache/ambari/pull/3375#issuecomment-1264400830
Thanks @smallyao , Could you help delete the following two lines
https://github.com/apache/ambari/blob/trunk/ambari-web/app/mappers/service_metrics_mapper.js#L137
https://github.com/apache/ambari/blob/trunk/ambari-web/app/models/service/mapreduce2.js#L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org