You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li...@inuus.com on 2010/05/12 03:57:03 UTC
merge together social/gadgets rpc/rest endpoints (issue1169044)
Reviewers: shindig.remailer_gmail.com,
Please review this at http://codereview.appspot.com/1169044/show
Affected files:
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
java/server/src/main/webapp/WEB-INF/web.xml
M java/server/src/test/java/org/apache/shindig/server/JettyLauncher.java
M
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
M
java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
M
java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java
M
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java
Re: merge together social/gadgets rpc/rest endpoints (issue1169044)
Posted by Paul Lindner <li...@inuus.com>.
Okay, point taken about directory structure..
Right now I'm concerned about
/gadgets/api/rpc and /gadgets/api/rest
Currently these provide the following features
http.get http.put http.post http.delete and cache.invalidate
I'd like to add an 'apps' set of RPCs to this endpoint, but I'd also like to be able to batch apps.* requests alongside social RPCs like people.get.
Thoughts?
On May 12, 2010, at 2:01 AM, Tim Wintle wrote:
> On Tue, 2010-05-11 at 19:01 -0700, Paul Lindner wrote:
>> So here's a start (patch below) to streamlining the way shindig works with
>> rpc and rest endpoints. I did this so I could batch gadgets and social
>> calls in the same request.
>>
>> Is anyone deeply attached to /social and /gadgets?
>
> At the moment it's possible to implement your own social apis in a
> separate language, and use a simple rewrite on these two directories to
> pass requests to the appropriate backend, while still making use of the
> gadgetserver.
>
> Am I correct that this change would tie you into extending the shindig
> classes if you wanted to implement both sides of the server? (or writing
> a request parser to split requests apart before proxying them to the
> appropriate backends)
>
> Out of interest, what benefits do we get from running off a flat
> directory structure? (except from batching two requests into a single
> call)
>
>
Re: Fwd: merge together social/gadgets rpc/rest endpoints (issue1169044)
Posted by Evgeny Bogdanov <ev...@epfl.ch>.
I also use currently java shindig for all /gadgets requests
and php shindig for all /social requests
On 12.05.10 11:01, Tim Wintle wrote:
> On Tue, 2010-05-11 at 19:01 -0700, Paul Lindner wrote:
>
>> So here's a start (patch below) to streamlining the way shindig works with
>> rpc and rest endpoints. I did this so I could batch gadgets and social
>> calls in the same request.
>>
>> Is anyone deeply attached to /social and /gadgets?
>>
> At the moment it's possible to implement your own social apis in a
> separate language, and use a simple rewrite on these two directories to
> pass requests to the appropriate backend, while still making use of the
> gadgetserver.
>
> Am I correct that this change would tie you into extending the shindig
> classes if you wanted to implement both sides of the server? (or writing
> a request parser to split requests apart before proxying them to the
> appropriate backends)
>
> Out of interest, what benefits do we get from running off a flat
> directory structure? (except from batching two requests into a single
> call)
>
>
>
>
Re: Fwd: merge together social/gadgets rpc/rest endpoints
(issue1169044)
Posted by Tim Wintle <ti...@teamrubber.com>.
On Tue, 2010-05-11 at 19:01 -0700, Paul Lindner wrote:
> So here's a start (patch below) to streamlining the way shindig works with
> rpc and rest endpoints. I did this so I could batch gadgets and social
> calls in the same request.
>
> Is anyone deeply attached to /social and /gadgets?
At the moment it's possible to implement your own social apis in a
separate language, and use a simple rewrite on these two directories to
pass requests to the appropriate backend, while still making use of the
gadgetserver.
Am I correct that this change would tie you into extending the shindig
classes if you wanted to implement both sides of the server? (or writing
a request parser to split requests apart before proxying them to the
appropriate backends)
Out of interest, what benefits do we get from running off a flat
directory structure? (except from batching two requests into a single
call)
Re: merge together social/gadgets rpc/rest endpoints (issue1169044)
Posted by Paul Lindner <pl...@linkedin.com>.
I didn't change web.xml all that much. I didn't want to make things too
complicated.
Basically I just changed all existing handlers references to use the new
consolidated handler set:
i.e.
- <param-value>org.apache.shindig.social.handlers</param-value>
+ <param-value>org.apache.shindig.handlers</param-value>
and
- <param-value>org.apache.shindig.gadgets.handlers</param-value>
+ <param-value>org.apache.shindig.handlers</param-value>
On Wed, May 12, 2010 at 10:37 AM, Henry Saputra <he...@gmail.com>wrote:
> Hi Paul,
>
> I cant see the diff for the web.xml in the codereview site.
> When I clicked at the view diff link it shows message:
> Upload in progress.
>
> - Henry
>
> On Tue, May 11, 2010 at 7:01 PM, Paul Lindner <li...@inuus.com> wrote:
>
> > So here's a start (patch below) to streamlining the way shindig works
> with
> > rpc and rest endpoints. I did this so I could batch gadgets and social
> > calls in the same request.
> >
> > Using Guice Multibindings it's easy to support a set of bindings that
> spans
> > multiple modules. Each module can add it's own implementations to set.
> >
> > This would then allow for a single /rpc and /rest endpont which could
> allow
> > for a flattened URL structure like so:
> >
> > /rpc
> > /rest
> > /ifr
> > /oauth
> > /js
> > /proxy
> > /concat
> > /oauthcallback
> > /accel
> >
> > # legacy
> > /makeRequest
> > /metadata
> >
> >
> > Is anyone deeply attached to /social and /gadgets?
> >
> >
> >
> >
> > ---------- Forwarded message ----------
> > From: <li...@inuus.com>
> > Date: Tue, May 11, 2010 at 6:57 PM
> > Subject: merge together social/gadgets rpc/rest endpoints (issue1169044)
> > To: shindig.remailer@gmail.com
> > Cc: reply@codereview.appspotmail.com
> >
> >
> > Reviewers: shindig.remailer_gmail.com,
> >
> >
> >
> > Please review this at http://codereview.appspot.com/1169044/show
> >
> > Affected files:
> > M
> >
> >
> java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
> > java/server/src/main/webapp/WEB-INF/web.xml
> > M java/server/src/test/java/org/apache/shindig/server/JettyLauncher.java
> > M
> >
> >
> java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
> > M
> >
> >
> java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
> > M
> >
> >
> java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java
> > M
> >
> >
> java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java
> >
>
Re: merge together social/gadgets rpc/rest endpoints (issue1169044)
Posted by Henry Saputra <he...@gmail.com>.
Hi Paul,
I cant see the diff for the web.xml in the codereview site.
When I clicked at the view diff link it shows message:
Upload in progress.
- Henry
On Tue, May 11, 2010 at 7:01 PM, Paul Lindner <li...@inuus.com> wrote:
> So here's a start (patch below) to streamlining the way shindig works with
> rpc and rest endpoints. I did this so I could batch gadgets and social
> calls in the same request.
>
> Using Guice Multibindings it's easy to support a set of bindings that spans
> multiple modules. Each module can add it's own implementations to set.
>
> This would then allow for a single /rpc and /rest endpont which could allow
> for a flattened URL structure like so:
>
> /rpc
> /rest
> /ifr
> /oauth
> /js
> /proxy
> /concat
> /oauthcallback
> /accel
>
> # legacy
> /makeRequest
> /metadata
>
>
> Is anyone deeply attached to /social and /gadgets?
>
>
>
>
> ---------- Forwarded message ----------
> From: <li...@inuus.com>
> Date: Tue, May 11, 2010 at 6:57 PM
> Subject: merge together social/gadgets rpc/rest endpoints (issue1169044)
> To: shindig.remailer@gmail.com
> Cc: reply@codereview.appspotmail.com
>
>
> Reviewers: shindig.remailer_gmail.com,
>
>
>
> Please review this at http://codereview.appspot.com/1169044/show
>
> Affected files:
> M
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
> java/server/src/main/webapp/WEB-INF/web.xml
> M java/server/src/test/java/org/apache/shindig/server/JettyLauncher.java
> M
>
> java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
> M
>
> java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
> M
>
> java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java
> M
>
> java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java
>
Fwd: merge together social/gadgets rpc/rest endpoints (issue1169044)
Posted by Paul Lindner <li...@inuus.com>.
So here's a start (patch below) to streamlining the way shindig works with
rpc and rest endpoints. I did this so I could batch gadgets and social
calls in the same request.
Using Guice Multibindings it's easy to support a set of bindings that spans
multiple modules. Each module can add it's own implementations to set.
This would then allow for a single /rpc and /rest endpont which could allow
for a flattened URL structure like so:
/rpc
/rest
/ifr
/oauth
/js
/proxy
/concat
/oauthcallback
/accel
# legacy
/makeRequest
/metadata
Is anyone deeply attached to /social and /gadgets?
---------- Forwarded message ----------
From: <li...@inuus.com>
Date: Tue, May 11, 2010 at 6:57 PM
Subject: merge together social/gadgets rpc/rest endpoints (issue1169044)
To: shindig.remailer@gmail.com
Cc: reply@codereview.appspotmail.com
Reviewers: shindig.remailer_gmail.com,
Please review this at http://codereview.appspot.com/1169044/show
Affected files:
M
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
java/server/src/main/webapp/WEB-INF/web.xml
M java/server/src/test/java/org/apache/shindig/server/JettyLauncher.java
M
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
M
java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
M
java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java
M
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java