You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2020/01/26 08:45:27 UTC
[GitHub] [incubator-nemo] wonook commented on a change in pull request #232:
[NEMO-411] Bug in ScheduleGroupPass, OutputTag, DuplicateEdgeGroup
wonook commented on a change in pull request #232: [NEMO-411] Bug in ScheduleGroupPass, OutputTag, DuplicateEdgeGroup
URL: https://github.com/apache/incubator-nemo/pull/232#discussion_r370982387
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -429,7 +434,11 @@ void addScheduleGroupCheckers() {
void addEncodingCompressionCheckers() {
final NeighborChecker additionalOutputEncoder = ((irVertex, inEdges, outEdges) -> {
- for (final List<IREdge> sameTagOutEdges : groupOutEdgesByAdditionalOutputTag(outEdges).values()) {
Review comment:
I'll refactor the private method then :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services