You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 12:01:44 UTC
[GitHub] [airflow] kaxil opened a new pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
kaxil opened a new pull request #16368:
URL: https://github.com/apache/airflow/pull/16368
If `DagBag.get_dag()` is called currently, it will return the DAG
even if the DAG does not exist in `serialized_dag` table.
This PR changes that logic to remove the dag from local cache too
when `DagBag.get_dag()` is called. This happens after
`min_serialized_dag_fetch_secs`.
TODO:
- [ ] Add test(s)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #16368:
URL: https://github.com/apache/airflow/pull/16368#discussion_r650109710
##########
File path: airflow/models/dagbag.py
##########
@@ -199,7 +201,14 @@ def get_dag(self, dag_id, session: Session = None):
dag_id=dag_id,
session=session,
)
- if sd_last_updated_datetime and sd_last_updated_datetime > self.dags_last_fetched[dag_id]:
+ if not sd_last_updated_datetime:
+ self.log.warning("Serialized DAG does not exist for '%s'", dag_id)
Review comment:
Updated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #16368:
URL: https://github.com/apache/airflow/pull/16368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16368:
URL: https://github.com/apache/airflow/pull/16368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16368:
URL: https://github.com/apache/airflow/pull/16368#discussion_r650099563
##########
File path: airflow/models/dagbag.py
##########
@@ -199,7 +201,14 @@ def get_dag(self, dag_id, session: Session = None):
dag_id=dag_id,
session=session,
)
- if sd_last_updated_datetime and sd_last_updated_datetime > self.dags_last_fetched[dag_id]:
+ if not sd_last_updated_datetime:
+ self.log.warning("Serialized DAG does not exist for '%s'", dag_id)
Review comment:
```suggestion
self.log.warning("Serialized DAG %s no longer exists", dag_id)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16368:
URL: https://github.com/apache/airflow/pull/16368#issuecomment-859698304
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #16368: Don't show stale Serialized DAGs if they are deleted in DB
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #16368:
URL: https://github.com/apache/airflow/pull/16368#discussion_r649565547
##########
File path: airflow/models/dagbag.py
##########
@@ -199,7 +201,13 @@ def get_dag(self, dag_id, session: Session = None):
dag_id=dag_id,
session=session,
)
- if sd_last_updated_datetime and sd_last_updated_datetime > self.dags_last_fetched[dag_id]:
+ if not sd_last_updated_datetime:
+ self.log.warning("Serialized DAG does not exist for '%s'", dag_id)
+ del self.dags[dag_id]
+ del self.dags_last_fetched[dag_id]
+ del self.dags_hash[dag_id]
+ return None
+ elif sd_last_updated_datetime > self.dags_last_fetched[dag_id]:
self._add_dag_from_db(dag_id=dag_id, session=session)
Review comment:
```suggestion
if sd_last_updated_datetime > self.dags_last_fetched[dag_id]:
self._add_dag_from_db(dag_id=dag_id, session=session)
```
nit, since we short circuit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org