You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/02/10 02:01:26 UTC
[GitHub] [incubator-livy] FourSwordKirby commented on a change in pull
request #278: [LIVY-748] Add support for running Livy Integration tests
against secure external clusters
FourSwordKirby commented on a change in pull request #278: [LIVY-748] Add support for running Livy Integration tests against secure external clusters
URL: https://github.com/apache/incubator-livy/pull/278#discussion_r376842433
##########
File path: integration-test/src/main/scala/org/apache/livy/test/framework/Cluster.scala
##########
@@ -45,20 +47,46 @@ trait Cluster {
def jdbcEndpoint: Option[String]
def hdfsScratchDir(): Path
+ def authScheme: String
+ def user: String
+ def password: String
+ def sslCertPath: String
+
def doAsClusterUser[T](task: => T): T
- lazy val hadoopConf = {
+ def initKubeConf(): Configuration = {
val conf = new Configuration(false)
configDir().listFiles().foreach { f =>
if (f.getName().endsWith(".xml")) {
conf.addResource(new Path(f.toURI()))
}
}
+ UserGroupInformation.setConfiguration(conf);
+ UserGroupInformation.loginUserFromKeytab(s"${user}@AZDATA.LOCAL",
+ s"/tests/kerberos_setup/${user}.keytab");
Review comment:
no those values shouldn't be hardcoded I just removed them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services