You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by RAbraham <gi...@git.apache.org> on 2014/07/30 20:58:01 UTC
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
GitHub user RAbraham opened a pull request:
https://github.com/apache/spark/pull/1666
[SPARK-2735][Documentation] Remove deprecation warning in 'jekyll build' for pygments
The following warning was corrected which shows up when one does 'jekyll build' in the docs folder
"Deprecation: The 'pygments' configuration option has been renamed to 'highlighter'. Please update your config file accordingly. The allowed values are 'rouge', 'pygments' or null."
Reference:https://github.com/mmistakes/hpstr-jekyll-theme/issues/25
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RAbraham/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1666
----
commit afd583dd1dd61ce91ed055d2e12e20dbc9d58286
Author: Rajiv Abraham <ra...@gmail.com>
Date: 2014-07-30T15:59:46Z
[SPARK-2735][Documentation] Remove deprecation warning in 'jekyll build' for pygments
The following warning was corrected
"Deprecation: The 'pygments' configuration option has been renamed to 'highlighter'. Please update your config file accordingly. The allowed values are 'rouge', 'pygments' or null."
Reference:https://github.com/mmistakes/hpstr-jekyll-theme/issues/25
commit 56957d2704176f2cf5f92d50216875c9979b87fc
Author: Rajiv Abraham <ra...@gmail.com>
Date: 2014-07-30T18:44:27Z
Merged [SPARK-2735][Documentation] Remove deprecation warning in 'jekyll build' for pygments
The following warning was corrected
"Deprecation: The 'pygments' configuration option has been renamed to 'highlighter'. Please update your config file accordingly. The allowed values are 'rouge', 'pygments' or null."
Reference:https://github.com/mmistakes/hpstr-jekyll-theme/issues/25
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1666#issuecomment-50921487
Hey @RAbraham - so it does seem that in the 1.X family of Jekyll releases, the "highlighter" option does not exist:
https://github.com/jekyll/jekyll/blob/1.0-branch/lib/jekyll/configuration.rb
So I'm inclined to leave this as-is for the moment since the current approach technically works with both versions. A lot of Spark packagers install jekyll with package managers and I think those aren't up to Jekyll 2.0 yet in most cases. So I think we should close this issue for now, but revisit it down the road.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
Posted by RAbraham <gi...@git.apache.org>.
Github user RAbraham commented on the pull request:
https://github.com/apache/spark/pull/1666#issuecomment-50924539
Sounds good. I will close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
Posted by RAbraham <gi...@git.apache.org>.
Github user RAbraham closed the pull request at:
https://github.com/apache/spark/pull/1666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1666#issuecomment-50804105
Do you know what the oldest version of Jekyll is that supports this option? We should definitely upgrade this, but I also want to make sure we don't break the build for people using older jekyll versions.
For a sample size of 1, here is the version I'm running:
```
$ jekyll -v
jekyll 1.1.2
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
Posted by RAbraham <gi...@git.apache.org>.
Github user RAbraham commented on the pull request:
https://github.com/apache/spark/pull/1666#issuecomment-50823324
This option seems to have changed from Jekyll 2.0 onwards(https://github.com/mmistakes/hpstr-jekyll-theme/issues/25). I have 2.1.1.
Since this is not a critical change(just removing a warning), it may not be worth the hassle of breaking peoples' builds. I can close this pull request if that is the most practical option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2735][Documentation] Remove deprecation...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1666#issuecomment-50663567
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---